bpo-35767: Fix unittest.loader to allow partials as test_functions [3.7] by fried · Pull Request #11600 · python/cpython · GitHub
Skip to content

bpo-35767: Fix unittest.loader to allow partials as test_functions [3.7] - #11600

Merged
ambv merged 2 commits into
python:masterfrom
fried:bpo-35767
Jan 23, 2019
Merged

bpo-35767: Fix unittest.loader to allow partials as test_functions [3.7]#11600
ambv merged 2 commits into
python:masterfrom
fried:bpo-35767

Conversation

@fried

@fried fried commented Jan 18, 2019 •
edited by bedevere-bot
Loading

Copy link
Copy Markdown
Contributor

This was a regression I first noticed in 3.7 branch.

https://bugs.python.org/issue35767

lisroach
lisroach approved these changes Jan 18, 2019
View reviewed changes

@lisroach lisroach left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This LGTM. Thank you!

tirkarthi
tirkarthi reviewed Jan 18, 2019
View reviewed changes
Comment thread Lib/unittest/test/test_loader.py Outdated

@tirkarthi tirkarthi Jan 18, 2019

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Minor nit: Extra blank line?

@fried fried Jan 18, 2019

Copy link
Copy Markdown
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

yep just removed the extra blank line.

@fried
Update test_loader.py
64fdd41 
removed an extra newline
@ambv
ambv merged commit fd628cf into python:master Jan 23, 2019
@bedevere-bot

bedevere-bot commented Jan 23, 2019

Copy link
Copy Markdown

@ambv: Please replace # with GH- in the commit message next time. Thanks!

@miss-islington

miss-islington commented Jan 23, 2019

Copy link
Copy Markdown
Contributor

Thanks @fried for the PR, and @ambv for merging it 🌮🎉.. I'm working now to backport this PR to: 3.7.
🐍🍒⛏🤖 I'm not a witch! I'm not a witch!

miss-islington pushed a commit to miss-islington/cpython that referenced this pull request Jan 23, 2019
@fried @miss-islington
bpo-35767: Fix unittest.loader to allow partials as test_functions (p…
5f910a3 
…ythonGH-11600)

(cherry picked from commit fd628cf)

Co-authored-by: Jason Fried <me@jasonfried.info>
@bedevere-bot

bedevere-bot commented Jan 23, 2019

Copy link
Copy Markdown

GH-11662 is a backport of this pull request to the 3.7 branch.

pitrou
pitrou reviewed Jan 23, 2019
View reviewed changes
Comment thread Lib/unittest/loader.py

@pitrou pitrou Jan 23, 2019

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The f-string is superfluous here.

@fried fried Jan 23, 2019

Copy link
Copy Markdown
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

good catch, it didn't wrap well as an f string, forgot to remove the f.

ambv pushed a commit that referenced this pull request Jan 24, 2019
@miss-islington @fried @ambv
bpo-35767: Fix unittest.loader to allow partials as test_functions (G…
841387d 
…H-11600) (#11662)

(cherry picked from commit fd628cf)

Co-authored-by: Jason Fried <me@jasonfried.info>
@fried
fried deleted the bpo-35767 branch September 24, 2024 16:37
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@pitrou pitrou pitrou left review comments
@tirkarthi tirkarthi tirkarthi left review comments
@lisroach lisroach lisroach approved these changes

Assignees

No one assigned

Labels

skip news

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

8 participants

@fried @bedevere-bot @miss-islington @pitrou @tirkarthi @lisroach @ambv @the-knights-who-say-ni