{{ message }}
gh-114258: Refactor Argument Clinic function name parser - #114930
Merged
erlend-aasland merged 12 commits intoFeb 15, 2024
Conversation
Yak-shaving in preparation for adding support for slots. - factor out return converter resolver - factor out cloning
Contributor
Author
This comment was marked as resolved.
This comment was marked as resolved.
erlend-aasland
marked this pull request as ready for review
February 3, 2024 01:15
Contributor
Author
|
FTR, most of this PR is just shuffling lines around and wrapping them in more targeted scopes. |
AlexWaygood
reviewed
Feb 5, 2024
sobolevn
reviewed
Feb 5, 2024
Contributor
Author
Member
|
Did you reject #114930 (comment) or missed it? :) Update: Ok, I see that it was partially implemented :) |
sobolevn
approved these changes
Feb 5, 2024
sobolevn
left a comment
sobolevn
left a comment
Member
There was a problem hiding this comment.
Thanks! We can work on better error messages in the next PRs.
Contributor
Author
Yeah, I think we should try to do an audit of all the |
Contributor
Author
|
Thanks for the review, Nikita. I'll wait a day or two to give Alex a chance to chime in (since I already pinged him about this). |
Contributor
Author
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Refactor state_modulename_name() of the parsing state machine, by
adding helpers for the sections that deal with ...: