gh-113317: Pass clinic to AC parse_arg() methods by vstinner · Pull Request #114319 · python/cpython · GitHub
Skip to content

gh-113317: Pass clinic to AC parse_arg() methods - #114319

Closed
vstinner wants to merge 1 commit into
python:mainfrom
vstinner:ac_pass_clinic
Closed

gh-113317: Pass clinic to AC parse_arg() methods#114319
vstinner wants to merge 1 commit into
python:mainfrom
vstinner:ac_pass_clinic

Conversation

@vstinner

@vstinner vstinner commented Jan 19, 2024 •
edited by bedevere-app Bot
Loading

Copy link
Copy Markdown
Member

Add 'clinic' parameter to Argument Clinic parse_arg() and bad_argument() methods. Remove usage of the 'clinic' global variable in these methods.

@vstinner
pythongh-113317: Pass clinic to AC parse_arg() methods
befdc3f 
Add 'clinic' parameter to Argument Clinic parse_arg() and
bad_argument() methods. Remove usage of the 'clinic' global variable
in these methods.
@bedevere-app bedevere-app Bot mentioned this pull request Jan 19, 2024
Closed
@vstinner

vstinner commented Jan 19, 2024

Copy link
Copy Markdown
Member Author

@erlend-aasland

erlend-aasland commented Jan 19, 2024

Copy link
Copy Markdown
Contributor

Sorry, I disagree with this approach 🙂 It would be better to teach CConverter.add_include to handle multiple includes per converter, and then in output_templates() fetch all includes from all the converters and add them via clinic.add_include(). If we teach CConverter.add_include that trick, we won't need clinic in bad_argument. Also, that will result in a much smaller diff! What do you think?

@vstinner

vstinner commented Jan 19, 2024

Copy link
Copy Markdown
Member Author

It would be better to teach CConverter.add_include to handle multiple includes per converter, and then in output_templates() fetch all includes from all the converters and add them via clinic.add_include().

Hum, that's strange: I already wrote an add_include() method in CConverter. In fact, bad_argument() can just reuse it.

I wrote PR #114324 which is way shorter.

@vstinner

vstinner commented Jan 19, 2024

Copy link
Copy Markdown
Member Author

@vstinner vstinner closed this Jan 19, 2024
@vstinner
vstinner deleted the ac_pass_clinic branch January 19, 2024 17:24
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@erlend-aasland erlend-aasland Awaiting requested review from erlend-aasland erlend-aasland is a code owner
@AlexWaygood AlexWaygood Awaiting requested review from AlexWaygood
@gpshead gpshead Awaiting requested review from gpshead gpshead is a code owner

Assignees

No one assigned

Labels

awaiting core review skip news

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

2 participants

@vstinner @erlend-aasland