{{ message }}
gh-114240: Skip verifying pip SBOM entry against PyPI if offline outside CI - #114255
Closed
sethmlarson wants to merge 1 commit into
Closed
gh-114240: Skip verifying pip SBOM entry against PyPI if offline outside CI#114255sethmlarson wants to merge 1 commit into
sethmlarson wants to merge 1 commit into
Conversation
Contributor
Contributor
Author
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Closes #114240 This PR implements my proposal from this comment: #114240 (comment)
We decide whether to
exit(1)or skip based on the presence of theCIenvironment variable. If there's another existing standard that we're using for this sort of behavior happy to use that instead.@befeleme Would this work for your use-case?