{{ message }}
gh-112087: Update list impl to be thread-safe with manual CS - #113863
Merged
Conversation
4 tasks
Member
Author
colesbury
approved these changes
Jan 11, 2024
colesbury
left a comment
colesbury
left a comment
Contributor
There was a problem hiding this comment.
Looks good other than the unused variable.
I scanned through listobject.c and it looks like there are still other functions that should be fairly straightforward to make thread-safe, such as list_copy_impl and list_append.
What do you mean by "xxx_lock implementations"?
Member
Author
|
@colesbury Updated PTAL :) |
Member
Author
It was about list_item_locked things that you updated implementations to use _Py_atomic_store/load operations. |
colesbury
approved these changes
Jan 15, 2024
colesbury
left a comment
colesbury
left a comment
Contributor
There was a problem hiding this comment.
LGTM.
I wonder if it's worth doing something to abstract out the locking in type slots (like tp_richcompare).
Member
Author
kulikjak
pushed a commit
to kulikjak/cpython
that referenced
this pull request
Jan 22, 2024
aisk
pushed a commit
to aisk/cpython
that referenced
this pull request
Feb 11, 2024
Glyphack
pushed a commit
to Glyphack/cpython
that referenced
this pull request
Sep 2, 2024
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
listobjects thread-safe in--disable-gilbuilds #112087