{{ message }}
gh-112535: Implement fallback implementation of _Py_ThreadId() - #113185
Merged
Conversation
Member
Author
colesbury
approved these changes
Dec 18, 2023
colesbury
left a comment
colesbury
left a comment
Contributor
There was a problem hiding this comment.
Some suggestions on code comments below. I think we should put any detailed explanations of _Py_GetThreadLocal_Addr near the implementation (and not where it's called in _Py_ThreadId().
I don't think there's a lot we can say generally about the implementation of &_Py_tss_tstate -- it depends on the platform, but adding a constant offset is generally not expensive. There are two common costs:
- Calling
_Py_GetThreadLocal_Addr(), which mostly can't be inlined. - Depending on the implementation of TLS, computing the address may or may not require another function call.
Contributor
There was a problem hiding this comment.
I think this should just be an #else. We're not using thread_local or depending on GNU specific features here in object.h.
Co-authored-by: Sam Gross <colesbury@gmail.com>
corona10
enabled auto-merge (squash)
December 18, 2023 16:32
ryan-duve
pushed a commit
to ryan-duve/cpython
that referenced
this pull request
Dec 26, 2023
…ythongh-113185) --------- Co-authored-by: Sam Gross <colesbury@gmail.com>
aisk
pushed a commit
to aisk/cpython
that referenced
this pull request
Feb 11, 2024
…ythongh-113185) --------- Co-authored-by: Sam Gross <colesbury@gmail.com>
Glyphack
pushed a commit
to Glyphack/cpython
that referenced
this pull request
Sep 2, 2024
…ythongh-113185) --------- Co-authored-by: Sam Gross <colesbury@gmail.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
_Py_ThreadId()work on PowerPC, IBM Z, etc. #112535