{{ message }}
gh-111964: Add _PyRWMutex a "readers-writer" lock - #112859
Merged
Merged
Conversation
This adds `_PyRWMutex`, a "readers-writer" lock, which wil be used to serialize global stop-the-world pauses with per-interpreter pauses.
Also, fix bug where `_PyRWMutex_Lock()` swapped the return/continue conditions leading to an extra iteration of the loop.
ericsnowcurrently
requested changes
Dec 13, 2023
ericsnowcurrently
left a comment
ericsnowcurrently
left a comment
Member
There was a problem hiding this comment.
Thanks for taking the time to split this out and address the other review comments I left on gh-112471. I've left a few here, including what might be a bug.
Also describe _PyRWMutex using bit patterns instead of ASCII art box. This matches how PyMutex is described.
Contributor
Author
|
(Fixed a typo in |
Member
|
@colesbury, I'm planning on merging this in the next hour or two. Let me know if you want me to wait. |
Contributor
Author
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This adds
_PyRWMutex, a "readers-writer" lock, which wil be used toserialize global stop-the-world pauses with per-interpreter pauses.
--disable-gilbuilds) #111964