[3.6] bpo-35257: Avoid leaking LTO linker flags into distutils (GH-10900) by vstinner · Pull Request #11265 · python/cpython · GitHub
Skip to content

[3.6] bpo-35257: Avoid leaking LTO linker flags into distutils (GH-10900) - #11265

Merged
ned-deily merged 3 commits into
python:3.6from
vstinner:ldflags_nodist36
Dec 20, 2018
Merged

[3.6] bpo-35257: Avoid leaking LTO linker flags into distutils (GH-10900)#11265
ned-deily merged 3 commits into
python:3.6from
vstinner:ldflags_nodist36

Conversation

@vstinner

@vstinner vstinner commented Dec 20, 2018 •
edited by bedevere-bot
Loading

Copy link
Copy Markdown
Member

vstinner and others added 2 commits December 20, 2018 15:10
@vstinner
bpo-35499: make profile-opt don't override CFLAGS_NODIST (GH-11164)
4af6fe7 
"make profile-opt" no longer replaces CFLAGS_NODIST with CFLAGS. It
now adds profile-guided optimization (PGO) flags to CFLAGS_NODIST,
existing CFLAGS_NODIST flags are kept.

(cherry picked from commit 640ed52)
@stratakis @vstinner
bpo-35257: Avoid leaking LTO linker flags into distutils (GH-10900)
f6a10d4 
When compiling 3rd party C extensions, the linker flags used by the
compiler for the interpreter and the stdlib modules, will get
leaked into distutils. In order to avoid that, the PY_CORE_LDFLAGS
and PY_LDFLAGS_NODIST are introduced to keep those flags separated.

(cherry picked from commit cf10a75)
@vstinner

vstinner commented Dec 20, 2018

Copy link
Copy Markdown
Member Author

@vstinner

vstinner commented Dec 20, 2018

Copy link
Copy Markdown
Member Author

cc @stratakis

@ned-deily

ned-deily commented Dec 20, 2018

Copy link
Copy Markdown
Member

Why did you combine the PRs from two separate issues into one? It would make things much easier to track if you kept them separate, no?

@vstinner

vstinner commented Dec 20, 2018

Copy link
Copy Markdown
Member Author

Why did you combine the PRs from two separate issues into one? It would make things much easier to track if you kept them separate, no?

The first commit isn't important, it's a minor change. But the second commit depends on the first commit. Otherwise, I would get even more conflicts on the backport. So I decided to combine both commits.

@ned-deily

ned-deily commented Dec 20, 2018

Copy link
Copy Markdown
Member

Please separate them. I spent a couple of hours earlier trying to decipher and document the tangled mess of the several bpo issues and PRs involved in this sequence over the various branches. Combining these just makes the mess more complicated.

@vstinner

vstinner commented Dec 20, 2018

Copy link
Copy Markdown
Member Author

I created PR #11267 for the first change.

@ned-deily
ned-deily merged commit a21bedf into python:3.6 Dec 20, 2018
@vstinner
vstinner deleted the ldflags_nodist36 branch December 20, 2018 20:45
@vstinner

vstinner commented Dec 20, 2018

Copy link
Copy Markdown
Member Author

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

No reviews

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

5 participants

@vstinner @ned-deily @the-knights-who-say-ni @bedevere-bot @stratakis