gh-112213: Update _weakref module to use new AC feature by corona10 · Pull Request #112250 · python/cpython · GitHub
Skip to content

gh-112213: Update _weakref module to use new AC feature - #112250

Merged
corona10 merged 4 commits into
python:mainfrom
corona10:gh-112213-weakref
Nov 19, 2023
Merged

corona10 merged 4 commits into
python:mainfrom
corona10:gh-112213-weakref

Conversation

@corona10

@corona10 corona10 commented Nov 18, 2023

Copy link
Copy Markdown
Member

@colesbury colesbury left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Great! Much nicer than manually writing the Py_BEGIN/END_CRITICAL_SECTION

@corona10

corona10 commented Nov 19, 2023

Copy link
Copy Markdown
Member Author

@corona10
corona10 merged commit 2bcc0f7 into python:main Nov 19, 2023
@corona10
corona10 deleted the gh-112213-weakref branch November 19, 2023 02:07
@colesbury

Copy link
Copy Markdown
Contributor

@corona10, we'll need to handle the thread-safety issues in _PyWeakref_IS_DEAD().

@corona10

Copy link
Copy Markdown
Member Author

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants