{{ message }}
gh-112026: Restore removed _PyDict_GetItemStringWithError() - #112119
Merged
Merged
Conversation
Restore the removed _PyDict_GetItemStringWithError() function. It is used by numpy.
Member
Author
Member
|
Is not PyObject *
_PyDict_GetItemStringWithError(PyObject *obj, const char *key)
{
PyObject *value;
(void)PyDict_GetItemStringRef(obj, key, &value);
if (Py_REFCNT(value) == 1) {
Py_DECREF(value);
return NULL;
}
Py_DECREF(value);
return value;
} |
Member
Author
Solution to which problem? numpy doesn't built if Python C API doesn't contain _PyDict_GetItemStringWithError(). I restored the function to unblock numpy. I plan to update numpy, deprecate _PyDict_GetItemStringWithError(), and later remove it. |
aisk
pushed a commit
to aisk/cpython
that referenced
this pull request
Feb 11, 2024
…thon#112119) Restore the removed _PyDict_GetItemStringWithError() function. It is used by numpy.
Contributor
See numpy/numpy#26282, would also appreciate code review if you have time. |
Member
Author
Glyphack
pushed a commit
to Glyphack/cpython
that referenced
this pull request
Sep 2, 2024
…thon#112119) Restore the removed _PyDict_GetItemStringWithError() function. It is used by numpy.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.

Restore the removed _PyDict_GetItemStringWithError() function. It is used by numpy.