gh-96954: Fix `make regen-unicodedata` in out-of-tree builds by hroncok · Pull Request #112118 · python/cpython · GitHub
Skip to content

gh-96954: Fix make regen-unicodedata in out-of-tree builds - #112118

Merged
vstinner merged 2 commits into
python:mainfrom
hroncok:out-of-tree-make-unicodedata
Nov 15, 2023
Merged

vstinner merged 2 commits into
python:mainfrom
hroncok:out-of-tree-make-unicodedata

Conversation

@hroncok

@hroncok hroncok commented Nov 15, 2023

Copy link
Copy Markdown
Contributor

This avoids:

python3.13 Tools/unicode/makeunicodedata.py
python3.13: can't open file '.../build/debug/Tools/unicode/makeunicodedata.py': [Errno 2] No such file or directory
make: *** [Makefile:1498: regen-unicodedata] Error 2

This avoids:

    python3.13 Tools/unicode/makeunicodedata.py
    python3.13: can't open file '.../build/debug/Tools/unicode/makeunicodedata.py': [Errno 2] No such file or directory
    make: *** [Makefile:1498: regen-unicodedata] Error 2
@vstinner

Copy link
Copy Markdown
Member

@vstinner

Copy link
Copy Markdown
Member

Please run make regen-unicodedata in the source directory and include changes of generated files in your PR. See: https://github.com/python/cpython/actions/runs/6879727597/job/18712327275?pr=112118

@hroncok

hroncok commented Nov 15, 2023

Copy link
Copy Markdown
Contributor Author

There's a typo in the second commit message. I know you don't like force pushing to PRs, so please correct it when squashing.

@vstinner
vstinner enabled auto-merge (squash) November 15, 2023 16:36
@vstinner
vstinner merged commit ec05507 into python:main Nov 15, 2023
@hroncok
hroncok deleted the out-of-tree-make-unicodedata branch November 15, 2023 16:49
@hroncok

hroncok commented Nov 15, 2023

Copy link
Copy Markdown
Contributor Author

Thanks.

@vstinner

Copy link
Copy Markdown
Member

aisk pushed a commit to aisk/cpython that referenced this pull request Feb 11, 2024
…ython#112118)

This avoids:

    python3.13 Tools/unicode/makeunicodedata.py
    python3.13: can't open file '.../build/debug/Tools/unicode/makeunicodedata.py': [Errno 2] No such file or directory
    make: *** [Makefile:1498: regen-unicodedata] Error 2

Re-run `make regen-unicodedata` to update the script path in generated files.
Glyphack pushed a commit to Glyphack/cpython that referenced this pull request Sep 2, 2024
…ython#112118)

This avoids:

    python3.13 Tools/unicode/makeunicodedata.py
    python3.13: can't open file '.../build/debug/Tools/unicode/makeunicodedata.py': [Errno 2] No such file or directory
    make: *** [Makefile:1498: regen-unicodedata] Error 2

Re-run `make regen-unicodedata` to update the script path in generated files.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants