gh-108303: Move `double_const` to `test_import` where it belongs by sobolevn · Pull Request #112108 · python/cpython · GitHub
Skip to content

gh-108303: Move double_const to test_import where it belongs - #112108

Merged
vstinner merged 6 commits into
python:mainfrom
sobolevn:issue-108303-test_import
Dec 11, 2023
Merged

gh-108303: Move double_const to test_import where it belongs#112108
vstinner merged 6 commits into
python:mainfrom
sobolevn:issue-108303-test_import

Conversation

@sobolevn

@sobolevn sobolevn commented Nov 15, 2023 •
edited by bedevere-app Bot
Loading

Copy link
Copy Markdown
Member

I think that initial PR just forgot about it :)

@sobolevn
sobolevn requested a review from vstinner November 15, 2023 07:14
@bedevere-app bedevere-app Bot mentioned this pull request Nov 15, 2023
Closed
@sobolevn sobolevn added skip news needs backport to 3.11 only security fixes needs backport to 3.12 only security fixes labels Nov 15, 2023
vstinner
vstinner reviewed Nov 15, 2023
View reviewed changes
Comment thread Lib/test/test_import/__init__.py Outdated
vstinner
vstinner reviewed Nov 15, 2023
View reviewed changes
Comment thread Lib/test/test_import/__init__.py Outdated
brettcannon
brettcannon reviewed Nov 15, 2023
View reviewed changes
Comment thread Lib/test/test_import/__init__.py Outdated
brettcannon
brettcannon previously requested changes Nov 17, 2023
View reviewed changes
Comment thread Lib/test/test_import/__init__.py Outdated
@bedevere-app

bedevere-app Bot commented Nov 17, 2023

Copy link
Copy Markdown

vstinner
vstinner reviewed Nov 30, 2023
View reviewed changes
Comment thread Lib/test/test_import/__init__.py Outdated
@sobolevn

sobolevn commented Dec 10, 2023

Copy link
Copy Markdown
Member Author

I have made the requested changes; please review again

vstinner
vstinner approved these changes Dec 11, 2023
View reviewed changes

@vstinner vstinner left a comment

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@vstinner
vstinner dismissed brettcannon’s stale review December 11, 2023 18:29

TEST_HOME_DIR is no longer imported.

@vstinner
vstinner merged commit 0738b9a into python:main Dec 11, 2023
@miss-islington-app

miss-islington-app Bot commented Dec 11, 2023

Copy link
Copy Markdown

Thanks @sobolevn for the PR, and @vstinner for merging it 🌮🎉.. I'm working now to backport this PR to: 3.11, 3.12.
🐍🍒⛏🤖

miss-islington pushed a commit to miss-islington/cpython that referenced this pull request Dec 11, 2023
@sobolevn @miss-islington
pythongh-108303: Move double_const to test_import where it belongs (
352cb98 
pythonGH-112108)

(cherry picked from commit 0738b9a)

Co-authored-by: Nikita Sobolev <mail@sobolevn.me>
@bedevere-app

bedevere-app Bot commented Dec 11, 2023

Copy link
Copy Markdown

GH-112976 is a backport of this pull request to the 3.12 branch.

@bedevere-app bedevere-app Bot removed the needs backport to 3.12 only security fixes label Dec 11, 2023
@bedevere-app

bedevere-app Bot commented Dec 11, 2023

Copy link
Copy Markdown

miss-islington pushed a commit to miss-islington/cpython that referenced this pull request Dec 11, 2023
@sobolevn @miss-islington
pythongh-108303: Move double_const to test_import where it belongs (
2b7b5d3 
pythonGH-112108)

(cherry picked from commit 0738b9a)

Co-authored-by: Nikita Sobolev <mail@sobolevn.me>
@bedevere-app bedevere-app Bot removed the needs backport to 3.11 only security fixes label Dec 11, 2023
vstinner pushed a commit that referenced this pull request Dec 11, 2023
@miss-islington @sobolevn
[3.11] gh-108303: Move double_const to test_import where it belon…
70e50c0 
…gs (GH-112108) (#112977)

gh-108303: Move `double_const` to `test_import` where it belongs (GH-112108)
(cherry picked from commit 0738b9a)

Co-authored-by: Nikita Sobolev <mail@sobolevn.me>
vstinner pushed a commit that referenced this pull request Dec 11, 2023
@miss-islington @sobolevn
[3.12] gh-108303: Move double_const to test_import where it belon…
ac8adf9 
…gs (GH-112108) (#112976)

gh-108303: Move `double_const` to `test_import` where it belongs (GH-112108)
(cherry picked from commit 0738b9a)

Co-authored-by: Nikita Sobolev <mail@sobolevn.me>
aisk pushed a commit to aisk/cpython that referenced this pull request Feb 11, 2024
@sobolevn @aisk
pythongh-108303: Move double_const to test_import where it belongs (
e2eb364 
python#112108)
Glyphack pushed a commit to Glyphack/cpython that referenced this pull request Sep 2, 2024
@sobolevn @Glyphack
pythongh-108303: Move double_const to test_import where it belongs (
436b567 
python#112108)
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@vstinner vstinner vstinner approved these changes
@brettcannon brettcannon brettcannon left review comments
@ericsnowcurrently ericsnowcurrently Awaiting requested review from ericsnowcurrently ericsnowcurrently is a code owner
@ncoghlan ncoghlan Awaiting requested review from ncoghlan ncoghlan is a code owner
@warsaw warsaw Awaiting requested review from warsaw warsaw is a code owner

Assignees

No one assigned

Labels

skip news

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

3 participants

@sobolevn @brettcannon @vstinner