{{ message }}
gh-108303: Move zip and tar archives to Lib/test/archivetestdata - #111549
Merged
Conversation
vstinner
reviewed
Oct 31, 2023
vstinner
left a comment
vstinner
left a comment
Member
There was a problem hiding this comment.
It's surprising that "ziptestdata" is used by test_tarfile and contains TAR archives. Maybe rename the directory to "archivetestdata"?
vstinner
changed the title
zip and tar archives to Lib/test/ziptestdatazip and tar archives to Lib/test/archivetestdata
vstinner
reviewed
Oct 31, 2023
vstinner
left a comment
vstinner
left a comment
Member
There was a problem hiding this comment.
Lib/test/archivetestdata/README.md says "Test data for test_zipfile". Maybe mention somewhere that now it's also used by test_tarfile, and also test_contextlib?
Also, the README file says "Purpose: These are used to test executable files with an appended zipfile". Is it still the case?
Member
vstinner
reviewed
Nov 3, 2023
vstinner
left a comment
vstinner
left a comment
Member
There was a problem hiding this comment.
Can you please try to fix the merge conflict?
Member
Author
|
Done! |
Member
aisk
pushed a commit
to aisk/cpython
that referenced
this pull request
Feb 11, 2024
Glyphack
pushed a commit
to Glyphack/cpython
that referenced
this pull request
Sep 2, 2024
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
All archives now live in the same place.