{{ message }}
bpo-35325:imp.find_module() return value documentation discrepancy - #11040
Merged
Merged
Conversation
ericsnowcurrently
requested changes
Dec 12, 2018
Member
|
You will want to add a NEWS entry. The "blurb" tool makes this easy. See the devguide for more info. Please be sure to add yourself to Misc/ACKS (in this PR) if you aren't there already. |
Member
|
I removed the " needs backport to 3.6" label, the 3.6 branch no long accept bugfixes (only security fixes are accepted): https://devguide.python.org/#status-of-python-branches |
Contributor
Author
|
I updated the PR based on @ericsnowcurrently 's review. Thank you. |
Contributor
|
Thanks @Windsooon for the PR, and @JulienPalard for merging it 🌮🎉.. I'm working now to backport this PR to: 3.7, 3.8. |
miss-islington
pushed a commit
to miss-islington/cpython
that referenced
this pull request
Sep 12, 2019
…ncy (pythonGH-11040) (cherry picked from commit 967b84c) Co-authored-by: Windson yang <wiwindson@outlook.com>
|
GH-16035 is a backport of this pull request to the 3.8 branch. |
miss-islington
pushed a commit
to miss-islington/cpython
that referenced
this pull request
Sep 12, 2019
…ncy (pythonGH-11040) (cherry picked from commit 967b84c) Co-authored-by: Windson yang <wiwindson@outlook.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
7 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
I'm not sure we should keep the change in Doc/library/imp.rst, feel free to edit it.
https://bugs.python.org/issue35325