iframe-proxy

ericsnowcurrently · 2023-10-03T22:32:00Z

Issue: test__xxinterpchannels leaks [21, 21, 21] references #110300

bedevere-bot · 2023-10-03T22:32:15Z

bedevere-bot · 2023-10-04T02:50:31Z

⚠️⚠️⚠️ Buildbot failure ⚠️⚠️⚠️

Hi! The buildbot s390x RHEL7 LTO 3.x has failed when building commit 269005e.

What do you need to do:

Don't panic.
Check the buildbot page in the devguide if you don't know what the buildbots are or how they work.
Go to the page of the buildbot that failed (https://buildbot.python.org/all/#builders/402/builds/5555) and take a look at the build logs.
Check if the failure is related to this commit (269005e) or if it is a false positive.
If the failure is related to this commit, please, reflect that on the issue and make a new Pull Request with a fix.

You can take a look at the buildbot page here:

https://buildbot.python.org/all/#builders/402/builds/5555

Failed tests:

test_tools

Failed subtests:

test_freeze_simple_script - test.test_tools.test_freeze.TestFreeze.test_freeze_simple_script

Summary of the results of the build (if available):

==

Click to see traceback logs

Traceback (most recent call last):
  File "/home/dje/cpython-buildarea/3.x.edelsohn-rhel-z.lto/build/Lib/test/test_tools/test_freeze.py", line 33, in test_freeze_simple_script
    executable = helper.freeze(python, scriptfile, outdir)
                 ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^
  File "/home/dje/cpython-buildarea/3.x.edelsohn-rhel-z.lto/build/Tools/freeze/test/freeze.py", line 165, in freeze
    _run_quiet([MAKE, '-C', os.path.dirname(scriptfile)])
  File "/home/dje/cpython-buildarea/3.x.edelsohn-rhel-z.lto/build/Tools/freeze/test/freeze.py", line 33, in _run_quiet
    return subprocess.run(
           ^^^^^^^^^^^^^^^
  File "/home/dje/cpython-buildarea/3.x.edelsohn-rhel-z.lto/build/Lib/subprocess.py", line 571, in run
    raise CalledProcessError(retcode, process.args,
subprocess.CalledProcessError: Command '['/usr/bin/make', '-C', '/tmp/test_python_abgk80sv/tmpomb679z8']' returned non-zero exit status 2.


Traceback (most recent call last):
  File "/home/dje/cpython-buildarea/3.x.edelsohn-rhel-z.lto/build/Lib/test/test_tools/test_freeze.py", line 33, in test_freeze_simple_script
    executable = helper.freeze(python, scriptfile, outdir)
                 ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^
  File "/home/dje/cpython-buildarea/3.x.edelsohn-rhel-z.lto/build/Tools/freeze/test/freeze.py", line 165, in freeze
    _run_quiet([MAKE, '-C', os.path.dirname(scriptfile)])
  File "/home/dje/cpython-buildarea/3.x.edelsohn-rhel-z.lto/build/Tools/freeze/test/freeze.py", line 33, in _run_quiet
    return subprocess.run(
           ^^^^^^^^^^^^^^^
  File "/home/dje/cpython-buildarea/3.x.edelsohn-rhel-z.lto/build/Lib/subprocess.py", line 571, in run
    raise CalledProcessError(retcode, process.args,
subprocess.CalledProcessError: Command '['/usr/bin/make', '-C', '/tmp/test_python_wd2pi5d7/tmpxc5n37vd']' returned non-zero exit status 2.

This restores their shareability, which was disabled by gh-110318 due to ref leaks.

…h-110607) This restores their shareability, which was disabled by pythongh-110318 due to ref leaks.

…channels (pythongh-110318)

…h-110607) This restores their shareability, which was disabled by pythongh-110318 due to ref leaks.

ericsnowcurrently added 4 commits October 3, 2023 15:41

Add a missing decref.

fbbebfd

Add more missing decrefs.

8bfdf89

Decref after get_module_from_owned_type().

47a2bf6

Stop leaking file descriptors.

b291931

ericsnowcurrently added the skip news label Oct 3, 2023

bedevere-app Bot added the awaiting review label Oct 3, 2023

bedevere-app Bot mentioned this pull request Oct 3, 2023

test__xxinterpchannels leaks [21, 21, 21] references #110300

Closed

ericsnowcurrently added 🔨 test-with-refleak-buildbots Test PR w/ refleak buildbots; report in status section and removed awaiting review labels Oct 3, 2023

bedevere-bot removed the 🔨 test-with-refleak-buildbots Test PR w/ refleak buildbots; report in status section label Oct 3, 2023

ericsnowcurrently mentioned this pull request Oct 3, 2023

gh-110266: Fix "get_module_from_owned_type is unused" warning #110269

Closed

ericsnowcurrently added 2 commits October 3, 2023 17:38

Merge branch 'main' into fix-refleaks

009aa91

Temporarily drop the _register_end_types() call.

bb7e4e0

ericsnowcurrently enabled auto-merge (squash) October 3, 2023 23:47

Temporarily skip a failing test.

2462033

ericsnowcurrently merged commit 269005e into python:main Oct 4, 2023

ericsnowcurrently deleted the fix-refleaks branch October 4, 2023 01:05

This was referenced Oct 4, 2023

gh-76785: Module-level Fixes for test.support.interpreters #110236

Merged

gh-76785: Make interpreters.*Channel Objects Shareable #110607

Merged

ericsnowcurrently added a commit that referenced this pull request Oct 19, 2023

gh-76785: Make interpreters.*Channel Objects Shareable (gh-110607)

d23a2f9

This restores their shareability, which was disabled by gh-110318 due to ref leaks.

ericsnowcurrently mentioned this pull request Nov 28, 2023

[3.12] gh-105716: Fix "Refleak" Failures in test_interpreters #112500

Merged

aisk pushed a commit to aisk/cpython that referenced this pull request Feb 11, 2024

pythongh-76785: Make interpreters.*Channel Objects Shareable (pythong…

4767753

…h-110607) This restores their shareability, which was disabled by pythongh-110318 due to ref leaks.

Glyphack pushed a commit to Glyphack/cpython that referenced this pull request Sep 2, 2024

pythongh-110300: Fix Refleaks in test_interpreters and test__xxinterp…

4e072be

…channels (pythongh-110318)

Glyphack pushed a commit to Glyphack/cpython that referenced this pull request Sep 2, 2024

pythongh-76785: Make interpreters.*Channel Objects Shareable (pythong…

efdf6f7

…h-110607) This restores their shareability, which was disabled by pythongh-110318 due to ref leaks.

Sunbelt Computer Software

PL/B Language Development and Support

Navigation Menu

Uh oh!

Uh oh!

gh-110300: Fix Refleaks in test_interpreters and test__xxinterpchannels - #110318

gh-110300: Fix Refleaks in test_interpreters and test__xxinterpchannels#110318
ericsnowcurrently merged 7 commits into
python:mainfrom
ericsnowcurrently:fix-refleaks

ericsnowcurrently commented Oct 3, 2023 •

edited by bedevere-app Bot

Loading

Uh oh!

bedevere-bot commented Oct 3, 2023

Uh oh!

bedevere-bot commented Oct 4, 2023

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

2 participants

Sunbelt Computer Software

PL/B Language Development and Support

Uh oh!

Uh oh!

Conversation

ericsnowcurrently commented Oct 3, 2023 • edited by bedevere-app Bot Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

bedevere-bot commented Oct 3, 2023

Uh oh!

bedevere-bot commented Oct 4, 2023

⚠️⚠️⚠️ Buildbot failure ⚠️⚠️⚠️

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

2 participants

ericsnowcurrently commented Oct 3, 2023 •

edited by bedevere-app Bot

Loading