gh-110119: Temporarily skip test_cppext on --disable-gil builds. by colesbury · Pull Request #110123 · python/cpython · GitHub
Skip to content

gh-110119: Temporarily skip test_cppext on --disable-gil builds. - #110123

Merged
carljm merged 1 commit into
python:mainfrom
colesbury:test_cpp_ext
Sep 29, 2023
Merged

carljm merged 1 commit into
python:mainfrom
colesbury:test_cpp_ext

Conversation

@colesbury

@colesbury colesbury commented Sep 29, 2023

Copy link
Copy Markdown
Contributor

The current version of pip does not support "t" in the ABI flags. Skip the test in --disable-gil builds until we can update pip.

The current version of pip does not support "t" in the ABI flags. Skip
the test in `--disable-gil` builds until we can update pip.
@colesbury

Copy link
Copy Markdown
Contributor Author

@bedevere-bot

Copy link
Copy Markdown

The regex 'noGIL' did not match any buildbot builder. Is the requested builder in the list of stable builders?

@colesbury

Copy link
Copy Markdown
Contributor Author

@itamaro - I don't think there's a way to run the PRs agains the noGIL build bots, maybe because they're not marked as stable? (Although considering I just broke them, maybe it's best they weren't marked stable)

@itamaro

itamaro commented Sep 29, 2023

Copy link
Copy Markdown
Contributor

@itamaro - I don't think there's a way to run the PRs agains the noGIL build bots, maybe because they're not marked as stable? (Although considering I just broke them, maybe it's best they weren't marked stable)

I don't know if the buildbot matching is case sensitive or not, and whether it matches against builder name (would be "NoGIL") of tags (would be "nogil").
@ambv do you know what we're matching against exactly? and whether it's possible to explicitly request to not ignore unstable buildbots?

@colesbury

Copy link
Copy Markdown
Contributor Author

It's no longer case sensitive (since yesterday when vstinner changed it)

@carljm
carljm merged commit 2973970 into python:main Sep 29, 2023
@bedevere-bot

Copy link
Copy Markdown

@colesbury
colesbury deleted the test_cpp_ext branch March 18, 2024 15:57
colesbury added a commit to colesbury/cpython that referenced this pull request Mar 18, 2024
…l builds. (python#110123)"

The `test_cppext` can run now that the `wheel` package is updated.

This reverts commit 2973970.
Glyphack pushed a commit to Glyphack/cpython that referenced this pull request Sep 2, 2024
python#110123)

The current version of pip does not support "t" in the ABI flags. Skip
the test in `--disable-gil` builds until we can update pip.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants