gh-109740: Use 't' in `--disable-gil` SOABI by colesbury · Pull Request #109922 · python/cpython · GitHub
Skip to content

gh-109740: Use 't' in --disable-gil SOABI - #109922

Merged
vstinner merged 8 commits into
python:mainfrom
colesbury:abi
Sep 27, 2023
Merged

vstinner merged 8 commits into
python:mainfrom
colesbury:abi

Conversation

@colesbury

@colesbury colesbury commented Sep 26, 2023

Copy link
Copy Markdown
Contributor

Shared libraries for CPython 3.13 --disable-gil builds are now marked with a 't' for threading. For example, binascii.cpython-313t-darwin.so.

Shared libraries for CPython 3.13 are now marked with a 't' for
threading. For example, `binascii.cpython-313t-darwin.so`.
@colesbury

colesbury commented Sep 26, 2023

Copy link
Copy Markdown
Contributor Author

Comment thread Misc/NEWS.d/next/Build/2023-09-26-16-00-50.gh-issue-109740.wboWdQ.rst Outdated
…WdQ.rst

Co-authored-by: Erlend E. Aasland <erlend.aasland@protonmail.com>
Comment thread Lib/test/test_sys.py
Comment thread configure.ac

@vstinner vstinner left a comment

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, but i left a few minor suggestions.

Comment thread Python/dynload_win.c
Comment thread configure.ac Outdated

@corona10 corona10 left a comment

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm!

@vstinner
vstinner enabled auto-merge (squash) September 27, 2023 08:07
@vstinner

Copy link
Copy Markdown
Member

I included my suggested changes to be able to merge your PR more quickly ;-)

@erlend-aasland

Copy link
Copy Markdown
Contributor

I included my suggested changes to be able to merge your PR more quickly ;-)

You need to regen configure.

@vstinner
vstinner disabled auto-merge September 27, 2023 08:38
@vstinner
vstinner enabled auto-merge (squash) September 27, 2023 08:39
@vstinner

Copy link
Copy Markdown
Member

You need to regen configure.

Oops. Otherwise, it would be too easy! Done.

@colesbury

Copy link
Copy Markdown
Contributor Author

Thanks!

@vstinner

Copy link
Copy Markdown
Member

Windows x64 unstable tests:

FAIL: test_future_times_out (test.test_concurrent_futures.test_as_completed.ThreadPoolAsCompletedTest.test_future_times_out) [0.01]

Should be already fixed by PR #109949.

FAIL: test_set_and_clear (test.test_threading.EventTests.test_set_and_clear)

I created issue #109974 for this failure.

@vstinner
vstinner merged commit 773614e into python:main Sep 27, 2023
@vstinner

Copy link
Copy Markdown
Member

Good, it got merged after a few CI hiccups :-)

@colesbury
colesbury deleted the abi branch September 27, 2023 15:29
csm10495 pushed a commit to csm10495/cpython that referenced this pull request Sep 28, 2023
Shared libraries for CPython 3.13 are now marked with a 't' for
threading. For example, `binascii.cpython-313t-darwin.so`.
@vstinner

vstinner commented Oct 4, 2023

Copy link
Copy Markdown
Member

Glyphack pushed a commit to Glyphack/cpython that referenced this pull request Sep 2, 2024
Shared libraries for CPython 3.13 are now marked with a 't' for
threading. For example, `binascii.cpython-313t-darwin.so`.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants