{{ message }}
bpo-29694: race condition in pathlib mkdir with flags parents=True - #1089
Merged
Merged
Conversation
arigo
changed the title
| got_exception = False | ||
| except FileExistsError: | ||
| got_exception = True | ||
| self.assertEqual(str(p12) in concurrently_created, got_exception) |
Member
There was a problem hiding this comment.
assertIn()/assertNotIn()? This will give more information in the case of failure.
try:
...
except FileExistsError:
self.assertIn(str(p12), concurrently_created)
else:
self.assertNotIn(str(p12), concurrently_created)
| os.mkdir(path, mode) # from another process | ||
| concurrently_created.add(path) | ||
| os.mkdir(path, mode) # our real call | ||
| org_mkdir = pathlib._normal_accessor.mkdir |
Member
There was a problem hiding this comment.
Seems this is not used.
| Library | ||
| ------- | ||
|
|
||
| - bpo-29694: race condition in pathlib mkdir with flags parents=True |
Member
There was a problem hiding this comment.
Add "Fixed" at the start, add a period at the end.
Member
|
In general LGTM, just few minor comments. |
serhiy-storchaka
added
type-bug
| # just before we try to create it ourselves. We do it | ||
| # in all possible pattern combinations, assuming that this | ||
| # function is called at most 5 times (dirCPC/dir1/dir2, | ||
| # dirCPC/dir1, dirCPC, dirCPC/dir1, cirCPC/dir1/dir2). |
Member
There was a problem hiding this comment.
cirCPC looks like a typo here.
| ------- | ||
|
|
||
| - bpo-29694: Fixed race condition in pathlib mkdir with flags | ||
| parents=True. |
Member
There was a problem hiding this comment.
You can also add "Patch by Armin Rigo.".
Member
There was a problem hiding this comment.
Since Armin is a core developer and will merge the PR himself this is not necessary.
Contributor
Author
|
I may be a core developer but nowadays I'd call this "historical reasons". I didn't commit anything for ages. Please merge this for me. |
Member
Mariatta
pushed a commit
to Mariatta/cpython
that referenced
this pull request
Apr 14, 2017
…rue (pythonGH-1089). (cherry picked from commit 22a594a)
Mariatta
pushed a commit
to Mariatta/cpython
that referenced
this pull request
Apr 14, 2017
…rue (pythonGH-1089). (cherry picked from commit 22a594a)
Mariatta
added a commit
that referenced
this pull request
Apr 14, 2017
Mariatta
added a commit
that referenced
this pull request
Apr 14, 2017
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
5 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No description provided.