{{ message }}
gh-108494: AC supports pos-only args in limited C API#108498
Merged
vstinner merged 1 commit intopython:mainfrom Aug 25, 2023
Merged
gh-108494: AC supports pos-only args in limited C API#108498vstinner merged 1 commit intopython:mainfrom
vstinner merged 1 commit intopython:mainfrom
Conversation
AC now checks for "#define Py_LIMITED_API" pattern to use the limited C API.
vstinner
force-pushed
the
ac_pos_limited
branch
from
8da84e6 to
c38deb5
Compare
Member
There was a problem hiding this comment.
It is not correct. In best case it is unused.
Member
Author
There was a problem hiding this comment.
Since AC and parsing arguments are complex, I propose to implement incrementally the limited C API. I'm not sure that I get your comment, when is it unused? Do you want to propose a fix?
AlexWaygood
reviewed
Aug 28, 2023
Member
AlexWaygood
left a comment
AlexWaygood
left a comment
There was a problem hiding this comment.
@vstinner, would you be able to add some documentation for this change to https://docs.python.org/3/howto/clinic.html? It would be useful information for users of Argument Clinic to know that they can generate code that only uses the limited C API by adding #define Py_LIMITED_API to a file
Member
Author
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
AC now checks for "#define Py_LIMITED_API" pattern to use the limited C API.