{{ message }}
gh-108278: Deprecate passing the three first params as keyword args for sqlite3 UDF creation APIs#108281
Merged
erlend-aasland merged 10 commits intopython:mainfrom Aug 28, 2023
Conversation
Deprecate passing name, number of arguments, and the callable as keyword arguments, for the following sqlite3.Connection APIs: - create_function(name, nargs, callable, ...) - create_aggregate(name, nargs, callable) Deprecate passing the callback as a keyword argument, for the following sqlite3.Connection APIs: - set_authorizer(callback) - set_progress_handler(callback, n) - set_trace_callback(callback) The affected parameters will become positional-only in Python 3.15.
erlend-aasland
changed the title
erlend-aasland
changed the title
Contributor
Author
erlend-aasland
commented
Aug 23, 2023
Contributor
Author
|
I'd like to land this; are you ok with the change, @serhiy-storchaka? |
Contributor
Author
|
I'm landing this. It is for |
serhiy-storchaka
approved these changes
Aug 28, 2023
Member
serhiy-storchaka
left a comment
serhiy-storchaka
left a comment
There was a problem hiding this comment.
LGTM, but please get an approval of yet one core developer. Has this change been discussed with a wider audience?
Contributor
Author
I posted a topic on Discourse. Brett and Berker left a "heart" reaction; I did not get any discouragements. Since Berker also is a code owner for the sqlite3 code, I count that as fairly strong support. |
Member
|
Well, then go ahead! |
vstinner
pushed a commit
to vstinner/cpython
that referenced
this pull request
Aug 28, 2023
…args for sqlite3 UDF creation APIs (python#108281) Deprecate passing name, number of arguments, and the callable as keyword arguments, for the following sqlite3.Connection APIs: - create_function(name, nargs, callable, ...) - create_aggregate(name, nargs, callable) The affected parameters will become positional-only in Python 3.15.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Deprecate passing name, number of arguments, and the callable as keyword
arguments, for the following sqlite3.Connection APIs:
The affected parameters will become positional-only in Python 3.15.
📚 Documentation preview 📚: https://cpython-previews--108281.org.readthedocs.build/