gh-106242: Make ntpath.realpath errors consistent with abspath when there are embedded nulls by zooba · Pull Request #108248 · python/cpython · GitHub
Skip to content

gh-106242: Make ntpath.realpath errors consistent with abspath when there are embedded nulls - #108248

Merged
zooba merged 2 commits into
python:mainfrom
zooba:gh-106242
Aug 22, 2023
Merged

gh-106242: Make ntpath.realpath errors consistent with abspath when there are embedded nulls#108248
zooba merged 2 commits into
python:mainfrom
zooba:gh-106242

Conversation

@zooba

@zooba zooba commented Aug 21, 2023

Copy link
Copy Markdown
Member

mention Windows and the former incorrect ValueError.

@gpshead gpshead left a comment

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I tweaked the news entry.

@gpshead gpshead added the type-bug An unexpected behavior, bug, or error label Aug 21, 2023
@zooba
zooba enabled auto-merge (squash) August 21, 2023 23:47
@zooba
zooba merged commit de33b5c into python:main Aug 22, 2023
@miss-islington

Copy link
Copy Markdown
Contributor

@bedevere-bot

Copy link
Copy Markdown

GH-108251 is a backport of this pull request to the 3.12 branch.

miss-islington pushed a commit to miss-islington/cpython that referenced this pull request Aug 22, 2023
…when there are embedded nulls (pythonGH-108248)

* pythongh-106242: Make ntpath.realpath errors consistent with abspath when there are embedded nulls

* Update 2023-08-22-00-36-57.gh-issue-106242.q24ITw.rst

mention Windows and the former incorrect ValueError.

---------

(cherry picked from commit de33b5c)

Co-authored-by: Steve Dower <steve.dower@python.org>
Co-authored-by: Gregory P. Smith <greg@krypto.org>
@bedevere-bot bedevere-bot removed the needs backport to 3.12 only security fixes label Aug 22, 2023
@bedevere-bot

Copy link
Copy Markdown

GH-108252 is a backport of this pull request to the 3.11 branch.

miss-islington pushed a commit to miss-islington/cpython that referenced this pull request Aug 22, 2023
…when there are embedded nulls (pythonGH-108248)

* pythongh-106242: Make ntpath.realpath errors consistent with abspath when there are embedded nulls

* Update 2023-08-22-00-36-57.gh-issue-106242.q24ITw.rst

mention Windows and the former incorrect ValueError.

---------

(cherry picked from commit de33b5c)

Co-authored-by: Steve Dower <steve.dower@python.org>
Co-authored-by: Gregory P. Smith <greg@krypto.org>
@bedevere-bot bedevere-bot removed the needs backport to 3.11 only security fixes label Aug 22, 2023
@bedevere-bot

Copy link
Copy Markdown

Yhg1s pushed a commit that referenced this pull request Aug 22, 2023
… when there are embedded nulls (GH-108248) (#108251)

gh-106242: Make ntpath.realpath errors consistent with abspath when there are embedded nulls (GH-108248)

* gh-106242: Make ntpath.realpath errors consistent with abspath when there are embedded nulls

* Update 2023-08-22-00-36-57.gh-issue-106242.q24ITw.rst

mention Windows and the former incorrect ValueError.

---------

(cherry picked from commit de33b5c)

Co-authored-by: Steve Dower <steve.dower@python.org>
Co-authored-by: Gregory P. Smith <greg@krypto.org>
@zooba
zooba deleted the gh-106242 branch August 22, 2023 14:34
zooba added a commit that referenced this pull request Aug 22, 2023
… when there are embedded nulls (GH-108248)

gh-106242: Make ntpath.realpath errors consistent with abspath when there are embedded nulls (GH-108248)

---------

(cherry picked from commit de33b5c)

Co-authored-by: Steve Dower <steve.dower@python.org>
Co-authored-by: Gregory P. Smith <greg@krypto.org>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

OS-windows type-bug An unexpected behavior, bug, or error

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants