Clarify state of CancelledError in doc by kristjanvalur · Pull Request #106453 · python/cpython · GitHub
Skip to content

Clarify state of CancelledError in doc#106453

Merged
gvanrossum merged 1 commit intopython:mainfrom
kristjanvalur:kristjan/doc-cancellederror
Jul 5, 2023
Merged

Clarify state of CancelledError in doc#106453
gvanrossum merged 1 commit intopython:mainfrom
kristjanvalur:kristjan/doc-cancellederror

Conversation

@kristjanvalur
Copy link
Copy Markdown
Contributor

@kristjanvalur kristjanvalur commented Jul 5, 2023 •
edited by github-actions Bot
Loading

This change makes it explicit that asyncio.CancelledError is not a subclass of Exception.
The previous wording technically allowed for the interpretation that it might also be an Exception, and that this were therefore somehow interpretation-defined. This change corresponds to the text in the "What's new in 3.8" section.

📚 Documentation preview 📚: https://cpython-previews--106453.org.readthedocs.build/

@bedevere-bot bedevere-bot added awaiting review docs Documentation in the Doc dir skip news labels Jul 5, 2023
gvanrossum
gvanrossum approved these changes Jul 5, 2023
View reviewed changes
Copy link
Copy Markdown
Member

@gvanrossum gvanrossum left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nitpicky, but sure.

@gvanrossum gvanrossum merged commit 12a9813 into python:main Jul 5, 2023
@gvanrossum gvanrossum added needs backport to 3.11 only security fixes needs backport to 3.12 only security fixes labels Jul 5, 2023
@miss-islington
Copy link
Copy Markdown
Contributor

miss-islington commented Jul 5, 2023

@miss-islington
Copy link
Copy Markdown
Contributor

miss-islington commented Jul 5, 2023

Thanks @kristjanvalur for the PR, and @gvanrossum for merging it 🌮🎉.. I'm working now to backport this PR to: 3.12.
🐍🍒⛏🤖

@miss-islington
Copy link
Copy Markdown
Contributor

miss-islington commented Jul 5, 2023

Sorry @kristjanvalur and @gvanrossum, I had trouble checking out the 3.11 backport branch.
Please retry by removing and re-adding the "needs backport to 3.11" label.
Alternatively, you can backport using cherry_picker on the command line.
cherry_picker 12a98138083589314d3da14bc97f2d8517947437 3.11

@bedevere-bot
Copy link
Copy Markdown

bedevere-bot commented Jul 5, 2023

GH-106454 is a backport of this pull request to the 3.12 branch.

@bedevere-bot bedevere-bot removed the needs backport to 3.12 only security fixes label Jul 5, 2023
@AlexWaygood AlexWaygood added needs backport to 3.11 only security fixes and removed needs backport to 3.11 only security fixes labels Jul 5, 2023
@miss-islington
Copy link
Copy Markdown
Contributor

miss-islington commented Jul 5, 2023

Thanks @kristjanvalur for the PR, and @gvanrossum for merging it 🌮🎉.. I'm working now to backport this PR to: 3.11.
🐍🍒⛏🤖

@bedevere-bot
Copy link
Copy Markdown

bedevere-bot commented Jul 5, 2023

@bedevere-bot bedevere-bot removed the needs backport to 3.11 only security fixes label Jul 5, 2023
miss-islington pushed a commit to miss-islington/cpython that referenced this pull request Jul 5, 2023
@kristjanvalur @miss-islington
Clarify state of CancelledError in doc (pythonGH-106453)
1f51288 
This change makes it explicit that asyncio.CancelledError is not a subclass of Exception.
(cherry picked from commit 12a9813)

Co-authored-by: Kristján Valur Jónsson <sweskman@gmail.com>
carljm added a commit to carljm/cpython that referenced this pull request Jul 5, 2023
@carljm
Merge branch 'main' into modulelocals
4c59e51 
* main: (39 commits)
  pythongh-102542 Remove unused bytes object and bytes slicing (python#106433)
  Clarify state of CancelledError in doc (python#106453)
  pythongh-64595: Fix regression in file write logic in Argument Clinic (python#106449)
  pythongh-104683: Rename Lib/test/clinic.test as Lib/test/clinic.test.c (python#106443)
  tp_flags docs: fix indentation (python#106420)
  pythongh-104050: Partially annotate Argument Clinic CLanguage class (python#106437)
  pythongh-106368: Add tests for formatting helpers in Argument Clinic (python#106415)
  pythongh-104050: Annotate Argument Clinic parameter permutation helpers (python#106431)
  pythongh-104050: Annotate toplevel functions in clinic.py (python#106435)
  pythongh-106320: Fix specialize.c compilation by including pycore_pylifecycle.h (python#106434)
  Add some codeowners for `Tools/clinic/` (python#106430)
  pythongh-106217: Truncate the issue body size of `new-bugs-announce-notifier` (python#106423)
  pythongh-61215: Rename `wait_until_any_call` to `wait_until_any_call_with` (python#106414)
  pythongh-106162: array: suppress warning in test_array (python#106404)
  pythongh-106320: Remove _PyInterpreterState_HasFeature() (python#106425)
  pythonGH-106360: Support very basic superblock introspection (python#106422)
  pythongh-106406: Fix _Py_IsInterpreterFinalizing() in _winapi.c (python#106408)
  pythongh-106396: Special-case empty format spec to gen empty JoinedStr node (python#106401)
  pythongh-106368: Add tests for permutation helpers in Argument Clinic (python#106407)
  pythonGH-106008: Fix refleak when peepholing `None` comparisons (python#106367)
  ...
gvanrossum pushed a commit that referenced this pull request Jul 5, 2023
@miss-islington @kristjanvalur
[3.11] Clarify state of CancelledError in doc (GH-106453) (#106456)
ada22db 
Clarify state of CancelledError in doc (GH-106453)

This change makes it explicit that asyncio.CancelledError is not a subclass of Exception.
(cherry picked from commit 12a9813)

Co-authored-by: Kristján Valur Jónsson <sweskman@gmail.com>
@kristjanvalur kristjanvalur deleted the kristjan/doc-cancellederror branch July 6, 2023 09:00
@kristjanvalur kristjanvalur mentioned this pull request Jul 6, 2023
Merged
11 tasks
kumaraditya303 pushed a commit that referenced this pull request Jul 6, 2023
@miss-islington @kristjanvalur
[3.12] Clarify state of CancelledError in doc (GH-106453) (#106454)
e229225 
Clarify state of CancelledError in doc (GH-106453)

This change makes it explicit that asyncio.CancelledError is not a subclass of Exception.
(cherry picked from commit 12a9813)

Co-authored-by: Kristján Valur Jónsson <sweskman@gmail.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@gvanrossum gvanrossum gvanrossum approved these changes

@1st1 1st1 Awaiting requested review from 1st1 1st1 is a code owner

@asvetlov asvetlov Awaiting requested review from asvetlov asvetlov is a code owner

@kumaraditya303 kumaraditya303 Awaiting requested review from kumaraditya303 kumaraditya303 is a code owner

@willingc willingc Awaiting requested review from willingc willingc is a code owner

Assignees

@gvanrossum gvanrossum

Labels

docs Documentation in the Doc dir skip issue skip news

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

5 participants

@kristjanvalur @miss-islington @bedevere-bot @gvanrossum @AlexWaygood