{{ message }}
gh-89886: Properly quote Autoconf macro arguments#105062
Merged
erlend-aasland merged 7 commits intopython:mainfrom May 30, 2023
Merged
gh-89886: Properly quote Autoconf macro arguments#105062erlend-aasland merged 7 commits intopython:mainfrom
erlend-aasland merged 7 commits intopython:mainfrom
Conversation
Autoconf 2.70 macros are picky about argument quotation.
erlend-aasland
added
skip news
🔨 test-with-buildbots
bedevere-bot
removed
the
🔨 test-with-buildbots
arhadthedev
reviewed
May 29, 2023
Contributor
Author
|
On hold until |
zware
reviewed
May 30, 2023
gpshead
reviewed
May 30, 2023
Contributor
Author
|
Thanks for the reviews, y'all! |
Contributor
Author
|
Here's some fun reading for you: https://www.gnu.org/software/autoconf/manual/autoconf-2.71/html_node/Coding-Style.html |
zware
approved these changes
May 30, 2023
Contributor
|
Thanks @erlend-aasland for the PR 🌮🎉.. I'm working now to backport this PR to: 3.12. |
Contributor
|
Sorry, @erlend-aasland, I could not cleanly backport this to |
|
GH-105118 is a backport of this pull request to the 3.12 branch. |
erlend-aasland
added a commit
to erlend-aasland/cpython
that referenced
this pull request
May 30, 2023
…n#105062) Autoconf 2.70 macros are picky about argument quotation.
erlend-aasland
added a commit
that referenced
this pull request
May 30, 2023
This was referenced Jun 1, 2023
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
6 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Autoconf 2.70 macros are picky about argument quotation.