gh-104773: PEP 594: Remove the aifc module by vstinner · Pull Request #104933 · python/cpython · GitHub
Skip to content

gh-104773: PEP 594: Remove the aifc module - #104933

Merged
vstinner merged 3 commits into
python:mainfrom
vstinner:remove_aifc
May 25, 2023
Merged

vstinner merged 3 commits into
python:mainfrom
vstinner:remove_aifc

Conversation

@vstinner

@vstinner vstinner commented May 25, 2023

Copy link
Copy Markdown
Member

@vstinner

Copy link
Copy Markdown
Member Author

@hugovk

hugovk commented May 25, 2023

Copy link
Copy Markdown
Member

Can we remove these test files as well?

./Lib/test/audiodata/pluck-ulaw.aifc
./Lib/test/audiodata/pluck-alaw.aifc
./Lib/test/Sine-1000Hz-300ms.aif

@vstinner

Copy link
Copy Markdown
Member Author

Someone else wrote a less complete PR: PR #104927.

* Remove .aifc and .aiff test files of Lib/test/audiodata/.
* Remove Lib/test/Sine-1000Hz-300ms.aif test file.
@vstinner

Copy link
Copy Markdown
Member Author

Can we remove these test files as well?

Right. I remove these test files and a few more.

@vstinner

Copy link
Copy Markdown
Member Author

With this change, test_wave becomes the last user of Lib/test/audiotests.py. I don't think that it's worth it to move the code into Lib/test/test_wave.py. I prefer to leave it as it is for now.

The two remaining AIFC test files are used by test_email:

Lib/test/test_email/data/sndhdr.aifc
Lib/test/test_email/data/sndhdr.aiff

@vstinner

Copy link
Copy Markdown
Member Author

The chunk module is related to AIFF: I wrote PR #104868 to remove it.

@vstinner

Copy link
Copy Markdown
Member Author

I added a What's New in Python 3.13 and Changelog entry.

@vstinner

Copy link
Copy Markdown
Member Author

A user disclosed that the post production film industry makes heavy use of the AIFC file format.

The VFX platform still uses Python 3.10 in 2023 ("CY2023"): https://vfxplatform.com/ Python will be upgraded to Python 3.11 next year ("CY2024 DRAFT").

@vstinner

Copy link
Copy Markdown
Member Author

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants