gh-104773: PEP 594: Remove the crypt module by vstinner · Pull Request #104908 · python/cpython · GitHub
Skip to content

gh-104773: PEP 594: Remove the crypt module - #104908

Merged
vstinner merged 1 commit into
python:mainfrom
vstinner:remove_crypt
May 25, 2023
Merged

gh-104773: PEP 594: Remove the crypt module#104908
vstinner merged 1 commit into
python:mainfrom
vstinner:remove_crypt

Conversation

@vstinner

@vstinner vstinner commented May 24, 2023 •
edited by github-actions Bot
Loading

Copy link
Copy Markdown
Member

Remove the crypt module and its private _crypt extension, deprecated in Python 3.11.

📚 Documentation preview 📚: https://cpython-previews--104908.org.readthedocs.build/

@bedevere-bot bedevere-bot mentioned this pull request May 24, 2023
Closed
19 tasks
@vstinner

vstinner commented May 24, 2023

Copy link
Copy Markdown
Member Author

@vstinner

vstinner commented May 24, 2023

Copy link
Copy Markdown
Member Author

passlib (1.7.4)

It's interesting that the proposed replacement for the removed crypt module actually uses crypt internally (in /passlib/utils/__init__.py) :-)

@hugovk

hugovk commented May 25, 2023

Copy link
Copy Markdown
Member

Are these bits still needed?

Lib/ctypes/util.py
366:            print(f"crypt\t:: {find_library('crypt')}")
367:            print(f"crypt\t:: {cdll.LoadLibrary(find_library('crypt'))}")
373:            print(find_library("crypt"))

@vstinner
pythongh-104773: PEP 594: Remove the crypt module
640eea3 
Remove the crypt module and its private _crypt extension, deprecated
in Python 3.11.
@vstinner

vstinner commented May 25, 2023

Copy link
Copy Markdown
Member Author

Are these bits still needed?

IMO we should keep it. I saw this test in ctypes. I don't see any direct relationship with the Python crypt module. It's just a test to load a dynamic library which is commonly available on Unix.

@corona10

corona10 commented May 25, 2023

Copy link
Copy Markdown
Member

@vstinner
vstinner merged commit e4127ea into python:main May 25, 2023
@vstinner
vstinner deleted the remove_crypt branch May 25, 2023 13:47
@Ahajha Ahajha mentioned this pull request Nov 29, 2024
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@hugovk hugovk hugovk approved these changes
@zware zware zware approved these changes
@erlend-aasland erlend-aasland Awaiting requested review from erlend-aasland erlend-aasland is a code owner
@corona10 corona10 Awaiting requested review from corona10 corona10 is a code owner

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

5 participants

@vstinner @hugovk @corona10 @zware @bedevere-bot