gh-102856: Update "Formatted string literals" docs section after PEP701 by lysnikolaou · Pull Request #104861 · python/cpython · GitHub
Skip to content

gh-102856: Update "Formatted string literals" docs section after PEP701#104861

Merged
lysnikolaou merged 1 commit intopython:mainfrom
lysnikolaou:lexical-analysis-pep701
May 24, 2023
Merged

gh-102856: Update "Formatted string literals" docs section after PEP701#104861
lysnikolaou merged 1 commit intopython:mainfrom
lysnikolaou:lexical-analysis-pep701

Conversation

@lysnikolaou
Copy link
Copy Markdown
Member

@lysnikolaou lysnikolaou commented May 24, 2023 •
edited by github-actions Bot
Loading

@bedevere-bot bedevere-bot mentioned this pull request May 24, 2023
Closed
4 tasks
@bedevere-bot bedevere-bot added docs Documentation in the Doc dir skip news labels May 24, 2023
@lysnikolaou lysnikolaou requested a review from pablogsal May 24, 2023 12:13
@pablogsal
Copy link
Copy Markdown
Member

pablogsal commented May 24, 2023

@pablogsal
Copy link
Copy Markdown
Member

pablogsal commented May 24, 2023

image

I mean this one

@lysnikolaou
Copy link
Copy Markdown
Member Author

lysnikolaou commented May 24, 2023

I think we need to fix also the "grammar" that is included here and substitute that for the PEG grammar

Not sure about that. The existing grammar feels easier to read. Since the purpose of this is to give an overview of what can go into an f-string, I don't think we should over-complicate stuff with FSTRING_START, FSTRING_END etc.

@pablogsal
Copy link
Copy Markdown
Member

pablogsal commented May 24, 2023

Hummmm IIRC that grammar is slightly incorrect or it was missing some details. Check it out and if you are happy with it then let's keep it

@lysnikolaou
Copy link
Copy Markdown
Member Author

lysnikolaou commented May 24, 2023

I briefly compared it with our version in the PEG and it seems okay to me. If you're also okay with it, we can merge.

pablogsal
pablogsal approved these changes May 24, 2023
View reviewed changes
Copy link
Copy Markdown
Member

@pablogsal pablogsal left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

Great work!

@lysnikolaou lysnikolaou added the needs backport to 3.12 only security fixes label May 24, 2023
@lysnikolaou lysnikolaou merged commit 8e5b3b9 into python:main May 24, 2023
@miss-islington
Copy link
Copy Markdown
Contributor

miss-islington commented May 24, 2023

Thanks @lysnikolaou for the PR 🌮🎉.. I'm working now to backport this PR to: 3.12.
🐍🍒⛏🤖

miss-islington pushed a commit to miss-islington/cpython that referenced this pull request May 24, 2023
@lysnikolaou @miss-islington
pythongh-102856: Update "Formatted string literals" docs section afte…
e867088 
…r PEP701 (pythonGH-104861)

(cherry picked from commit 8e5b3b9)

Co-authored-by: Lysandros Nikolaou <lisandrosnik@gmail.com>
@bedevere-bot
Copy link
Copy Markdown

bedevere-bot commented May 24, 2023

@bedevere-bot bedevere-bot removed the needs backport to 3.12 only security fixes label May 24, 2023
lysnikolaou added a commit that referenced this pull request May 24, 2023
@miss-islington @lysnikolaou
[3.12] gh-102856: Update "Formatted string literals" docs section aft…
25890eb 
…er PEP701 (GH-104861) (#104865)

(cherry picked from commit 8e5b3b9)

Co-authored-by: Lysandros Nikolaou <lisandrosnik@gmail.com>
@erlend-aasland erlend-aasland mentioned this pull request Jun 6, 2023
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@pablogsal pablogsal pablogsal approved these changes

Assignees

No one assigned

Labels

docs Documentation in the Doc dir skip news

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

4 participants

@lysnikolaou @pablogsal @miss-islington @bedevere-bot