{{ message }}
gh-91896: Improve visibility of ByteString deprecation warnings#104294
Merged
hauntsaninja merged 3 commits intopython:mainfrom May 12, 2023
Merged
gh-91896: Improve visibility of ByteString deprecation warnings#104294hauntsaninja merged 3 commits intopython:mainfrom
ByteString deprecation warnings#104294hauntsaninja merged 3 commits intopython:mainfrom
Conversation
AlexWaygood
requested review from
Fidget-Spinner,
JelleZijlstra,
gvanrossum and
rhettinger
as code owners
Member
Author
AlexWaygood
force-pushed
the
more-bytestring-warnings
branch
from
8c469cf to
8015ba3
Compare
Eclips4
reviewed
May 8, 2023
Contributor
|
I'm not opposed to this but think it isn't necessary. We aren't required to emit warnings. The deprecation notices in whatsnew and the docs will suffice. This doubly true for ByteString which like has low use. |
Member
Author
hauntsaninja
reviewed
May 9, 2023
Contributor
hauntsaninja
left a comment
hauntsaninja
left a comment
There was a problem hiding this comment.
Thanks! While collections.abc.ByteString is extremely low use, there is some use of typing.ByteString as an annotation out there, for which this could help.
Either way we should lean on type checkers for this deprecation as well, since we won't get warnings in stub files or some from __future__ import annotations scenarios.
hauntsaninja
approved these changes
May 12, 2023
This was referenced May 12, 2023
carljm
added a commit
to carljm/cpython
that referenced
this pull request
May 12, 2023
* main: pythongh-91896: Fixup some docs issues following ByteString deprecation (python#104422) pythonGH-104371: check return value of calling `mv.release` (python#104417) pythongh-104415: Fix refleak tests for `typing.ByteString` deprecation (python#104416) pythonGH-86275: Implementation of hypothesis stubs for property-based tests, with zoneinfo tests (python#22863) pythonGH-103082: Filter LINE events in VM, to simplify tool implementation. (pythonGH-104387) pythongh-93649: Split gc- and allocation tests from _testcapimodule.c (pythonGH-104403) pythongh-104389: Add 'unused' keyword to Argument Clinic C converters (python#104390) pythongh-101819: Prepare _io._IOBase for module state (python#104386) pythongh-104413: Fix refleak when super attribute throws AttributeError (python#104414) Fix refleak in `super_descr_get` (python#104408) pythongh-87526: Remove dead initialization from _zoneinfo parse_abbr() (python#24700) pythongh-91896: Improve visibility of `ByteString` deprecation warnings (python#104294) pythongh-104371: Fix calls to `__release_buffer__` while an exception is active (python#104378) pythongh-104377: fix cell in comprehension that is free in outer scope (python#104394) pythongh-104392: Remove _paramspec_tvars from typing (python#104393) pythongh-104396: uuid.py to skip platform check for emscripten and wasi (pythongh-104397) pythongh-99108: Refresh HACL* from upstream (python#104401) pythongh-104301: Allow leading whitespace in disambiguated pdb statements (python#104342)
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
5 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
#102096 added deprecation warnings for
collections.abc.ByteString, but these warnings are currently only emitted on subclassingByteStringor callingisinstance()against it. ImportingByteStringor accessing it viaimport collections.abc; collections.abc.ByteStringdoes not currently trigger any warnings, meaning somebody who's just using the class for type annotations might not get any warning that the class will be removed in 3.14. Moreover, theisinstance()deprecation warnings are only emitted onisinstance()checks againstcollections.abc.ByteString, not onisinstance()checks againsttyping.ByteString. The docs update that we just made in 1f56795 says thattyping.ByteStringwill also be removed in Python 3.14, so we should emit the same deprecation warnings fortyping.ByteString.This PR adds deprecation warnings for:
from collections.abc import ByteStringimport collections.abc; collections.abc.ByteStringfrom typing import ByteStringimport typing; typing.ByteStringisinstance(b"", typing.ByteString)