{{ message }}
Optimize set.pop() to advance a pointer instead of indexing. - #10429
Merged
Merged
Conversation
Contributor
Author
serhiy-storchaka
left a comment
serhiy-storchaka
left a comment
Member
There was a problem hiding this comment.
Could you please provide microbenchmarks?
In most cases the loop ends after 1 or 2 iterations. Additional operations before and after the loop can eat the benefit of the optimization of short loop.
| entry->hash = -1; | ||
| so->used--; | ||
| so->finger = i + 1; /* next place to start */ | ||
| so->finger = entry - so->table; /* next place to start */ |
Contributor
Author
There was a problem hiding this comment.
Yes. Thanks for noticing.
Contributor
Author
|
I can't run new benchmarks right now (my build has been broken for a couple of days since the extensive include file changes went in). The benchmark looked like this: |
Contributor
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
5 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Gives approx 20% speed-up using clang depending on the number of elements in the set (the less dense the set, the more the speed-up).
Uses the same entry++ logic used elsewhere in the setobject.c code.