gh-103879: Fix refleak in super specialization#103882
gh-103879: Fix refleak in super specialization#103882JelleZijlstra merged 1 commit intopython:mainfrom
Conversation
JelleZijlstra
added
the
🔨 test-with-refleak-buildbots
bedevere-bot
removed
the
🔨 test-with-refleak-buildbots
carljm
left a comment
carljm
left a comment
There was a problem hiding this comment.
Ugh, sorry about this and for wasting so much of your time tracking these down on your PEP 695 work yesterday!
I thought I'd run the refleak buildbots on the specialization PR, not sure what happened. I think maybe I triggered them but the buildbot fleet was backed up, and so they didn't actually start running for a long time, and then I later rebased the PR again assuming they had run and passed? Will be more careful checking that in future.
Your changes here look correct to me, since the res cached in the inline cache should be a borrowed reference (as noted in the comment), not a strong reference.
Approving, assuming the signal all looks green.
|
I think there may be an issue where the default buildbot run doesn't include the refleak buildbots. If you look at the commits on github.com/python/cpython, the most recent ones are green, even though the buildbot website shows the refleak buildbots failing on main. |
4 participants
Uh oh!
There was an error while loading. Please reload this page.