{{ message }}
Conversation
|
All commit authors signed the Contributor License Agreement. |
JustBeYou
force-pushed
the
gh-103498
branch
2 times, most recently
from
April 13, 2023 21:35
ec4f0b7 to
1b3c821
Compare
JustBeYou
marked this pull request as ready for review
April 13, 2023 21:38
… exit if exit_on_error=False
Contributor
|
@sobolevn , do you think this is a good fix? I can add tests to this :) |
Author
|
Taking a closer look at the problem, I don't see the proposed fix as suitable anymore. I think that to properly solve the problem with |
Member
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fix for #103498
Summary:
ArgumentParser.errormethod based onexit_on_errorparameterraise ArgumentErrorwithself.error()inArgumentParserArgumentParser.error, namelyaction=Nonebecause raisingArgumentErrorrequires itNote:
ArgumentParser; a solution to this would be to use**kwargsinstead, but seems kind of dirty to me. suggestions appreciated