gh-67230: document new csv quoting modes in whatsnew (gh-103491) by smontanaro · Pull Request #103491 · python/cpython · GitHub
Skip to content

gh-67230: document new csv quoting modes in whatsnew (gh-103491)#103491

Merged
merwok merged 3 commits intopython:mainfrom
smontanaro:patch-4
Apr 13, 2023
Merged

gh-67230: document new csv quoting modes in whatsnew (gh-103491)#103491
merwok merged 3 commits intopython:mainfrom
smontanaro:patch-4

Conversation

@smontanaro
Copy link
Copy Markdown
Contributor

@smontanaro smontanaro commented Apr 12, 2023

Add blurb about recent change to csv.

Add blurb about changes to :mod:`csv`.
@bedevere-bot bedevere-bot added docs Documentation in the Doc dir skip news awaiting review labels Apr 12, 2023
@merwok merwok changed the title Update 3.12.rst bpo-67230: document new csv quoting modes in whatsnew Apr 12, 2023
@merwok merwok changed the title bpo-67230: document new csv quoting modes in whatsnew gh-67230: document new csv quoting modes in whatsnew Apr 12, 2023
Comment thread Doc/whatsnew/3.12.rst Outdated
Comment thread Doc/whatsnew/3.12.rst Outdated
@bedevere-bot
Copy link
Copy Markdown

Comment thread Doc/whatsnew/3.12.rst Outdated
@merwok merwok self-assigned this Apr 12, 2023
@smontanaro
Copy link
Copy Markdown
Contributor Author

This interface is horrible. I see a change was rewuested by @merwok but can't see what it is. So...

I have made the requested changes; please review again.

@bedevere-bot
Copy link
Copy Markdown

Thanks for making the requested changes!

@merwok: please review the changes made to this pull request.

@bedevere-bot bedevere-bot requested a review from merwok April 13, 2023 00:41
@merwok
Copy link
Copy Markdown
Member

merwok commented Apr 13, 2023

I see a change was requested by merwok but can't see what it is. So...

Ah! «requested changes» is a review status (others are «approved» and «commented»)
Comments can be standalone or part of a review; I used the latter mode, made a few comments (some being change suggestions) and published my review with the «changes requested» status. Then I applied some of my suggested changes directly. So you saw «changes requested», some hidden comments («resolved» by the application of the suggestion), and one comment about the wording.

@merwok merwok changed the title gh-67230: document new csv quoting modes in whatsnew gh-67230: document new csv quoting modes in whatsnew (gh-103491) Apr 13, 2023
@merwok merwok merged commit fb38c1b into python:main Apr 13, 2023
@samwyse
Copy link
Copy Markdown
Contributor

samwyse commented Apr 13, 2023

@smontanaro looks good! I tried to do this myself last night, but I was at my kid's soccer practice and discovered that the official iPhone GitHub app does not have all the functionality of the web GUI. 😢

@smontanaro
Copy link
Copy Markdown
Contributor Author

smontanaro commented Apr 13, 2023 via email

aisk pushed a commit to aisk/cpython that referenced this pull request Apr 18, 2023
@chaeynz
Copy link
Copy Markdown

chaeynz commented Oct 6, 2023

@smontanaro were you responsible for the csv.QUOTE_NULL?

You're an absolute legend!
I am working a project where I need exactly this, thank you so much! :)

@smontanaro
Copy link
Copy Markdown
Contributor Author

KNGSJ

This comment was marked as off-topic.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

docs Documentation in the Doc dir skip news

Projects

None yet

Development

Successfully merging this pull request may close these issues.

6 participants