{{ message }}
gh-102839: remove AC for math.log - #102863
Merged
Merged
Conversation
Before: $ ./python -m timeit -s 'from math import log' 'log(1.1)' 1000000 loops, best of 5: 344 nsec per loop $ ./python -m timeit -s 'from math import log' 'log(1.1, 3.2)' 500000 loops, best of 5: 601 nsec per loop After: $ ./python -m timeit -s 'from math import log' 'log(1.1)' 2000000 loops, best of 5: 171 nsec per loop $ ./python -m timeit -s 'from math import log' 'log(1.1, 3.2)' 1000000 loops, best of 5: 348 nsec per loop
sobolevn
reviewed
Mar 21, 2023
Member
There was a problem hiding this comment.
Can you please add a comment about why it is not converted to AC?
…jRi12.rst Co-authored-by: Nikita Sobolev <mail@sobolevn.me>
corona10
reviewed
Mar 21, 2023
corona10
left a comment
corona10
left a comment
Member
There was a problem hiding this comment.
I don't think that this is what we have to go.
See: faster-cpython/ideas#565
Contributor
|
If and when the AC gets improved, we can convert this back to AC. In the meantime, let's take the performance win. We will see immediate benefits in some of the random module distribution calculations. |
Contributor
|
@skirpichev My timings are about 7x faster than yours. Are you using a debug build for timings, a non-representative machine, or an older compiler? |
Contributor
|
@mdickinson Are you on board with this? |
Member
|
@rhettinger Yep, fine by me. Looks like a significant performance boost. |
Member
Author
Fidget-Spinner
pushed a commit
to Fidget-Spinner/cpython
that referenced
this pull request
Mar 27, 2023
warsaw
pushed a commit
to warsaw/cpython
that referenced
this pull request
Apr 11, 2023
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
6 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Before:
After: