{{ message }}
gh-102296 Document that inspect.Parameter kinds support ordering#102297
Merged
miss-islington merged 2 commits intopython:mainfrom Feb 27, 2023
Merged
gh-102296 Document that inspect.Parameter kinds support ordering#102297miss-islington merged 2 commits intopython:mainfrom
miss-islington merged 2 commits intopython:mainfrom
Conversation
AlexWaygood
reviewed
Feb 27, 2023
Member
AlexWaygood
left a comment
AlexWaygood
left a comment
There was a problem hiding this comment.
It doesn't look like we currently have any tests asserting that the inspect.Parameter kinds support ordering. I'm not sure we should document it if it's untested, as that means that it could break in the future without anybody noticing. Would you be interested in adding a test to https://github.com/python/cpython/blob/main/Lib/test/test_inspect.py as part of this PR?
Contributor
Author
Member
Thanks, not sure how I missed that! |
AlexWaygood
reviewed
Feb 27, 2023
Co-authored-by: Alex Waygood <Alex.Waygood@Gmail.com>
AlexWaygood
added
🤖 automerge
needs backport to 3.10
Contributor
|
Status check is done, and it's a success ✅. |
Contributor
|
Thanks @Gouvernathor for the PR 🌮🎉.. I'm working now to backport this PR to: 3.10, 3.11. |
|
GH-102298 is a backport of this pull request to the 3.11 branch. |
miss-islington
pushed a commit
to miss-islington/cpython
that referenced
this pull request
Feb 27, 2023
pythonGH-102297) (cherry picked from commit 0db6f44) Co-authored-by: Gouvernathor <44340603+Gouvernathor@users.noreply.github.com> Automerge-Triggered-By: GH:AlexWaygood
miss-islington
pushed a commit
to miss-islington/cpython
that referenced
this pull request
Feb 27, 2023
pythonGH-102297) (cherry picked from commit 0db6f44) Co-authored-by: Gouvernathor <44340603+Gouvernathor@users.noreply.github.com> Automerge-Triggered-By: GH:AlexWaygood
miss-islington
added a commit
that referenced
this pull request
Feb 27, 2023
miss-islington
added a commit
that referenced
this pull request
Feb 27, 2023
carljm
added a commit
to carljm/cpython
that referenced
this pull request
Feb 28, 2023
* main: (67 commits) pythongh-99108: Add missing md5/sha1 defines to Modules/Setup (python#102308) pythongh-100227: Move _str_replace_inf to PyInterpreterState (pythongh-102333) pythongh-100227: Move the dtoa State to PyInterpreterState (pythongh-102331) pythonGH-102305: Expand some macros in generated_cases.c.h (python#102309) Migrate to new PSF mailgun account (python#102284) pythongh-102192: Replace PyErr_Fetch/Restore etc by more efficient alternatives (in Python/) (python#102193) pythonGH-90744: Fix erroneous doc links in the sys module (python#101319) pythongh-87092: Make jump target label equal to the offset of the target in the instructions sequence (python#102093) pythongh-101101: Unstable C API tier (PEP 689) (pythonGH-101102) IDLE: Simplify DynOptionsMenu __init__code (python#101371) pythongh-101561: Add typing.override decorator (python#101564) pythongh-101825: Clarify that as_integer_ratio() output is always normalized (python#101843) pythongh-101773: Optimize creation of Fractions in private methods (python#101780) pythongh-102251: Updates to test_imp Toward Fixing Some Refleaks (pythongh-102254) pythongh-102296 Document that inspect.Parameter kinds support ordering (pythonGH-102297) pythongh-102250: Fix double-decref in COMPARE_AND_BRANCH error case (pythonGH-102287) pythongh-101100: Fix sphinx warnings in `types` module (python#102274) pythongh-91038: Change default argument value to `False` instead of `0` (python#31621) pythongh-101765: unicodeobject: use Py_XDECREF correctly (python#102283) [doc] Improve grammar/fix missing word (pythonGH-102060) ...
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Automerge-Triggered-By: GH:AlexWaygood