gh-101766: Fix refleak for _BlockingOnManager resources from test suite level by corona10 · Pull Request #101988 · python/cpython · GitHub
Skip to content

gh-101766: Fix refleak for _BlockingOnManager resources from test suite level#101988

Merged
corona10 merged 2 commits intopython:mainfrom
corona10:gh-101766-revert
Feb 17, 2023
Merged

gh-101766: Fix refleak for _BlockingOnManager resources from test suite level#101988
corona10 merged 2 commits intopython:mainfrom
corona10:gh-101766-revert

Conversation

@corona10
Copy link
Copy Markdown
Member

@corona10 corona10 commented Feb 17, 2023

@corona10 corona10 changed the title Revert "gh-101766: Fix refleak for _BlockingOnManager resources (gh-1… gh-101766: Fix refleak for _BlockingOnManager resources from test suite level Feb 17, 2023
@corona10 corona10 requested a review from gvanrossum February 17, 2023 13:20
@corona10
Copy link
Copy Markdown
Member Author

corona10 commented Feb 17, 2023

@corona10 corona10 added the 🔨 test-with-refleak-buildbots Test PR w/ refleak buildbots; report in status section label Feb 17, 2023
@bedevere-bot
Copy link
Copy Markdown

🤖 New build scheduled with the buildbot fleet by @corona10 for commit a85f0e6 🤖

If you want to schedule another build, you need to add the 🔨 test-with-refleak-buildbots label again.

@bedevere-bot bedevere-bot removed the 🔨 test-with-refleak-buildbots Test PR w/ refleak buildbots; report in status section label Feb 17, 2023
Copy link
Copy Markdown
Member

@sobolevn sobolevn left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Wow, this turned out way more complex than I initially thought! 👍

Copy link
Copy Markdown
Member

@gvanrossum gvanrossum left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This works too. Many tests do something like this. Is there standard infrastructure for clearing caches?

@corona10
Copy link
Copy Markdown
Member Author

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants