iframe-proxy

terryjreedy · 2018-10-28T07:48:58Z

https://bugs.python.org/issue1529353

taleinat

Great additions! I really should have added these myself when adding Squeezer.

I have only a couple of comments.

taleinat · 2018-10-28T07:59:06Z

 Python Shell window
 ^^^^^^^^^^^^^^^^^^^

+IDLE's Shell window is a specialized editor window that also responds


IDLE's Shell window is a specialized editor window

While technically correct, I find this confusing and think most users will too. If the goal is to explain that the shell window responds to most (all?) of the editor windows' keyboard shortcuts, I recommend writing that more explicitly.

taleinat · 2018-10-28T08:00:07Z

+
+Squeeze
+   If the cursor is over an output line, squeeze all the output between
+   the code above and the prompt below down to a 'Squeezed text' button.


a 'Squeezed text' button

While it's implemented as a button, it doesn't quite behave like one, so this may be confusing to users. Perhaps "a 'Squeezed text' label"?

Suggested change

the code above and the prompt below down to a 'Squeezed text' button.

the code above and the prompt below down to a 'Squeezed text' label.

(later in the doc as well)

terryjreedy · 2018-10-28T08:36:55Z

Thank you for the suggestions. Github has a new feature for making and accepting suggestions. When you click on the blue button with white +, the left most icon is a page with + over -. The tool tip is 'make a suggestion'. It is supposed to turn a suggestion into a mini-diff, which I should be able to accept. It will then apply the diff as a mini commit. Can you try it so I can see how it works from the PR author side?

taleinat · 2018-10-28T08:47:51Z

+<dl class="docutils">
+<dt>Squeeze</dt>
+<dd>If the cursor is over an output line, squeeze all the output between
+the code above and the prompt below down to a ‘Squeezed text’ button.</dd>


Suggested change

the code above and the prompt below down to a ‘Squeezed text’ button.</dd>

the code above and the prompt below down to a ‘Squeezed text’ label.</dd>

This looks like it would work great, except I just realized that IDLE doc changes have to be made in parallel in both the .rst and .html files. That is easiest to do by changing the .rst on my machine and then generating the revised .html with Sphinx.

taleinat · 2018-10-28T08:48:07Z

 </li>
 </ul>
+<p>Shell also has a special facility for squeezing output lines down to a
+‘Squeezed text’ button.  This is done automatically for output over N lines


Suggested change

‘Squeezed text’ button. This is done automatically for output over N lines

‘Squeezed text’ label. This is done automatically for output over N lines

taleinat · 2018-10-28T08:48:23Z

+(N = 50 by default).  N can be changed in the PyShell section of the General
+page of the Settings dialog.  Fewer lines can be squeezed by right clicking
+on the output.  This can be useful for extra long lines.  Squeezed output can
+be expanded in place by double-clicking the button.  It can instead be sent


Suggested change

be expanded in place by double-clicking the button. It can instead be sent

be expanded in place by double-clicking the label. It can instead be sent

taleinat · 2018-10-28T08:48:35Z

+page of the Settings dialog.  Fewer lines can be squeezed by right clicking
+on the output.  This can be useful for extra long lines.  Squeezed output can
+be expanded in place by double-clicking the button.  It can instead be sent
+to the clipboard or a separate view window by right-clicking the button.</p>


Suggested change

to the clipboard or a separate view window by right-clicking the button.</p>

to the clipboard or a separate view window by right-clicking the label.</p>

taleinat · 2018-10-28T08:48:57Z

  * :kbd:`Return` while on any previous command retrieves that command

+Shell also has a special facility for squeezing output lines down to a
+'Squeezed text' button.  This is done automatically for output over N lines


Suggested change

'Squeezed text' button. This is done automatically for output over N lines

'Squeezed text' label. This is done automatically for output over N lines

taleinat · 2018-10-28T08:49:12Z

+(N = 50 by default).  N can be changed in the PyShell section of the General
+page of the Settings dialog.  Fewer lines can be squeezed by right clicking
+on the output.  This can be useful for extra long lines.  Squeezed output can
+be expanded in place by double-clicking the button.  It can instead be sent


Suggested change

be expanded in place by double-clicking the button. It can instead be sent

be expanded in place by double-clicking the label. It can instead be sent

taleinat · 2018-10-28T08:49:27Z

+page of the Settings dialog.  Fewer lines can be squeezed by right clicking
+on the output.  This can be useful for extra long lines.  Squeezed output can
+be expanded in place by double-clicking the button.  It can instead be sent
+to the clipboard or a separate view window by right-clicking the button.


Suggested change

to the clipboard or a separate view window by right-clicking the button.

to the clipboard or a separate view window by right-clicking the label.

taleinat · 2018-10-28T08:51:09Z

I gave the "Suggestion" feature a shot but I'm not thrilled with the experience. Suggestions are each limited to a single line. In this case, at least, I'd have preferred somehow supplying a diff, e.g. a PR for merging into this branch.

In it's current form it seems great for suggesting fixes for typos, minor grammatical errors, minor style issues etc., but ISTM that's about it.

terryjreedy · 2018-10-28T16:41:48Z

Editing someone else's PR by pulling and pushing is described in the devguide. But only core devs can do so. Socially, this works better when the author is not, unless one asks first. Until she becomes a core dev, Cheryl could make line suggestions (such as when changing markup).

I need to learn to pull such edits into my branch, especially for edits to idle.rst (so I can generate the matching help.html).

In any case, I replaced 'shell is editor' and changed 'button' to 'label'. Buttons should respond to a single click, and these don't. I am going to merge and work on another IDLE doc issue.

bedevere-bot · 2018-10-28T16:44:47Z

@terryjreedy: Please replace # with GH- in the commit message next time. Thanks!

miss-islington · 2018-10-28T16:44:47Z

Thanks @terryjreedy for the PR 🌮🎉.. I'm working now to backport this PR to: 3.6, 3.7.
🐍🍒⛏🤖

bedevere-bot · 2018-10-28T16:44:59Z

GH-10179 is a backport of this pull request to the 3.7 branch.

…10169) (cherry picked from commit 68d6dc0) Co-authored-by: Terry Jan Reedy <tjreedy@udel.edu>

bedevere-bot · 2018-10-28T16:45:14Z

…10169) (cherry picked from commit 68d6dc0) Co-authored-by: Terry Jan Reedy <tjreedy@udel.edu>

(cherry picked from commit 68d6dc0) Co-authored-by: Terry Jan Reedy <tjreedy@udel.edu>

bpo-1529353: Explain Shell text squeezing in the IDLE doc.

3b8c749

terryjreedy added needs backport to 3.6 docs Documentation in the Doc dir skip news labels Oct 28, 2018

terryjreedy self-assigned this Oct 28, 2018

bedevere-bot added the awaiting merge label Oct 28, 2018

the-knights-who-say-ni added the CLA signed label Oct 28, 2018

taleinat reviewed Oct 28, 2018

View reviewed changes

Apply Tal's comments.

04da4ff

terryjreedy merged commit 68d6dc0 into python:master Oct 28, 2018

bedevere-bot removed the awaiting merge label Oct 28, 2018

terryjreedy deleted the squeeze branch October 28, 2018 16:44

bedevere-bot removed the needs backport to 3.7 label Oct 28, 2018

miss-islington pushed a commit to miss-islington/cpython that referenced this pull request Oct 28, 2018

bpo-1529353: Explain Shell text squeezing in the IDLE doc. (pythonGH-…

f0ac3ee

…10169) (cherry picked from commit 68d6dc0) Co-authored-by: Terry Jan Reedy <tjreedy@udel.edu>

bedevere-bot removed the needs backport to 3.6 label Oct 28, 2018

miss-islington pushed a commit to miss-islington/cpython that referenced this pull request Oct 28, 2018

bpo-1529353: Explain Shell text squeezing in the IDLE doc. (pythonGH-…

4e33c26

…10169) (cherry picked from commit 68d6dc0) Co-authored-by: Terry Jan Reedy <tjreedy@udel.edu>

miss-islington added a commit that referenced this pull request Oct 28, 2018

bpo-1529353: Explain Shell text squeezing in the IDLE doc. (GH-10169)

8dccb00

(cherry picked from commit 68d6dc0) Co-authored-by: Terry Jan Reedy <tjreedy@udel.edu>

miss-islington added a commit that referenced this pull request Oct 28, 2018

bpo-1529353: Explain Shell text squeezing in the IDLE doc. (GH-10169)

69ab28d

(cherry picked from commit 68d6dc0) Co-authored-by: Terry Jan Reedy <tjreedy@udel.edu>

	the code above and the prompt below down to a 'Squeezed text' button.
	the code above and the prompt below down to a 'Squeezed text' label.

	‘Squeezed text’ button. This is done automatically for output over N lines
	‘Squeezed text’ label. This is done automatically for output over N lines

	be expanded in place by double-clicking the button. It can instead be sent
	be expanded in place by double-clicking the label. It can instead be sent

	to the clipboard or a separate view window by right-clicking the button.</p>
	to the clipboard or a separate view window by right-clicking the label.</p>

	'Squeezed text' button. This is done automatically for output over N lines
	'Squeezed text' label. This is done automatically for output over N lines

Sunbelt Computer Software

PL/B Language Development and Support

Uh oh!

Uh oh!

Conversation

terryjreedy commented Oct 28, 2018 • edited by bedevere-bot Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

taleinat left a comment

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

taleinat Oct 28, 2018 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Choose a reason for hiding this comment

Uh oh!

terryjreedy commented Oct 28, 2018

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

taleinat commented Oct 28, 2018 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

terryjreedy commented Oct 28, 2018

Uh oh!

bedevere-bot commented Oct 28, 2018

Uh oh!

miss-islington commented Oct 28, 2018

Uh oh!

bedevere-bot commented Oct 28, 2018

Uh oh!

bedevere-bot commented Oct 28, 2018

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

5 participants

terryjreedy commented Oct 28, 2018 •

edited by bedevere-bot

Loading

taleinat Oct 28, 2018 •

edited

Loading

taleinat commented Oct 28, 2018 •

edited

Loading