{{ message }}
gh-101357: use os.path.exists() etc from pathlib - #101361
Closed
barneygale wants to merge 1 commit into
Closed
Conversation
The following `pathlib.Path` methods now directly call functions in `os.path`: - `samefile()` - `exists()` - `is_dir()` - `is_file()` - `is_symlink()` In conjunction with python#101324, this improves performance of these methods by using making fewer system calls than `stat()` The original generic implementations of these methods are preserved in a new, internal `_PathWithStat` class. In future this may form the basis of a public `AbstractPath` class. The generic implementation of `is_mount()`, which was removed in 29650fea, is also restored to this class.
Contributor
Contributor
Author
We added a similar strict keyword-only argument to |
Contributor
Author
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The following
pathlib.Pathmethods now directly call functions inos.path:samefile()exists()is_dir()is_file()is_symlink()In conjunction with #101324, this improves performance of these methods by using making fewer system calls than
stat()The original generic implementations of these methods are preserved in a new, internal
_PathWithStatclass. In future this may form the basis of a publicAbstractPathclass. The generic implementation ofis_mount(), which was removed in 29650fea, is also restored to this class.pathlib.Path.is_fileand friends #101357