{{ message }}
gh-89381: Fix signature for math.log and cmath.log - #101115
Closed
hauntsaninja wants to merge 2 commits into
Closed
hauntsaninja wants to merge 2 commits into
hauntsaninja wants to merge 2 commits into
Conversation
The optional group in math.log seems unnecessary, as far as I can tell. Once we remove this, Argument Clinic knows what to do. For cmath, we just do what math is doing, which is use c_default = NULL (so the actual runtime logic is unchanged), but mark cmath.e as the fake default value.
Member
mdickinson
self-requested a review
January 19, 2023 16:28
Member
Agreed on both points; I prefer the solution in #101070. |
Member
|
@mdickinson, I can restore #101070, if you wish. But after #101123 I'm not sure that a broken signature is an issue for CPython. |
Member
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The optional group in math.log seems unnecessary, as far as I can tell. Once we remove this, Argument Clinic knows what to do.
For
cmath, we just do whatmathis already doing: usec_default = NULL(so the actual runtime logic is unchanged), but markcmath.eas the fake default value.