Link to PR-specific grid in PR message by zware · Pull Request #576 · python/buildmaster-config · GitHub
Skip to content

Link to PR-specific grid in PR message - #576

Merged
zware merged 1 commit into
python:mainfrom
zware:fix_pr_grid_link
Feb 16, 2025
Merged

zware merged 1 commit into
python:mainfrom
zware:fix_pr_grid_link

Conversation

@zware

@zware zware commented Jan 24, 2025

Copy link
Copy Markdown
Member

Also add the link to 'command' PR runs rather than just 'label' runs.

Expansion of #571; ref #327.

Also add the link to 'command' PR runs rather than just 'label' runs.

Expansion of python#571; ref python#327.
@zware
zware requested review from hugovk and vstinner January 24, 2025 00:14

@vstinner vstinner left a comment

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

It seems to be good to me, but I didn't try the URL :-)

@hugovk

hugovk commented Jan 24, 2025

Copy link
Copy Markdown
Member

@zware

zware commented Feb 8, 2025

Copy link
Copy Markdown
Member Author

@hugovk hugovk left a comment

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Well, this is still an improvement, thanks!

@zware
zware merged commit bb43ee6 into python:main Feb 16, 2025
@zware
zware deleted the fix_pr_grid_link branch February 20, 2025 16:03
zware added a commit to zware/buildmaster-config that referenced this pull request Feb 26, 2025
Fixes python#578, a bug introduced by python#576 for python#327.

I was mislead by the number extraction in another part of the file.
encukou pushed a commit that referenced this pull request Feb 27, 2025
Fixes #578, a bug introduced by #576 for #327.

I was mislead by the number extraction in another part of the file.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants