Do not fail issue number test for all PRs with ``skip issue`` label by DanielNoord · Pull Request #487 · python/bedevere · GitHub
Skip to content

Do not fail issue number test for all PRs with skip issue label - #487

Merged
ezio-melotti merged 1 commit into
python:mainfrom
DanielNoord:issue
Oct 10, 2022
Merged

ezio-melotti merged 1 commit into
python:mainfrom
DanielNoord:issue

Conversation

@DanielNoord

Copy link
Copy Markdown
Contributor

Closes #468.

This check should be done before we get any other information.

I had to change some test data because they were "incomplete". I could also check for the label on the old lines 52-54, but then we would unnecessarily validate the issue number we found in the title. Thought it made more sense to do it like this.

@codecov

codecov Bot commented Jul 8, 2022

Copy link
Copy Markdown

@vsajip

vsajip commented Oct 1, 2022

Copy link
Copy Markdown
Member

The change in gh_issue.py looks good to me - but I would need more time to get my head around the test code 🙁

@ezio-melotti
ezio-melotti merged commit 71e7252 into python:main Oct 10, 2022
@DanielNoord
DanielNoord deleted the issue branch October 10, 2022 19:28
@ezio-melotti

Copy link
Copy Markdown
Member

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

Status: Done

Development

Successfully merging this pull request may close these issues.

Fails issue number check even with skip-issue set

3 participants