{{ message }}
This repository was archived by the owner on Dec 23, 2024. It is now read-only.
Improve typing hints - #537
Merged
Merged
Conversation
KunoiSayami
suggested changes
Nov 29, 2020
KunoiSayami
left a comment
KunoiSayami
left a comment
Contributor
There was a problem hiding this comment.
Use Optional[X] may more intuitive than Union[X, None]
Reference: https://docs.python.org/3/library/typing.html#typing.Optional
alissonlauffer
force-pushed
the
typing-fixes
branch
from
November 29, 2020 06:37
73689e0 to
e517d3b
Compare
KunoiSayami
approved these changes
Nov 29, 2020
alissonlauffer
force-pushed
the
typing-fixes
branch
2 times, most recently
from
November 29, 2020 22:26
ecc796c to
a26e648
Compare
KunoiSayami
approved these changes
Nov 30, 2020
alissonlauffer
force-pushed
the
typing-fixes
branch
2 times, most recently
from
December 8, 2020 20:32
36df8dc to
e45fea1
Compare
delivrance
reviewed
Dec 11, 2020
delivrance
reviewed
Dec 11, 2020
alissonlauffer
force-pushed
the
typing-fixes
branch
from
December 11, 2020 18:34
e45fea1 to
696596f
Compare
alissonlauffer
force-pushed
the
typing-fixes
branch
from
December 14, 2020 04:22
696596f to
9a19636
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Proposed changes
type1 or type2toUnion[type1, type2]because the first one is not a valid syntax for typing hints (though it does not give any SyntaxError).Union[type1, None]toOptional[type1]as proposed in Improve typing hints #537 (review).