Fix conflicting classification of install by covracer · Pull Request #1572 · pypa/packaging.python.org · GitHub
Skip to content

Fix conflicting classification of install#1572

Merged
webknjaz merged 3 commits into
pypa:mainfrom
covracer:patch-1
Sep 24, 2024
Merged

Fix conflicting classification of install#1572
webknjaz merged 3 commits into
pypa:mainfrom
covracer:patch-1

Conversation

@covracer

@covracer covracer commented Jul 12, 2024

Copy link
Copy Markdown
Contributor

Lines 21 to 23 state that the install command must not be run anymore.


📚 Documentation preview 📚: https://python-packaging-user-guide--1572.org.readthedocs.build/en/1572/

The first paragraph says the command must not be run anymore.

@webknjaz webknjaz left a comment

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for the change! None of the commands should be run anymore. I think that this just states for the record that things still exist, but the document does not provide suggestions on how to deal with them right now. Removing one but leaving the others doesn't feel right. Not sure we'd want it in this form.

@sinoroc

sinoroc commented Jul 13, 2024

Copy link
Copy Markdown
Contributor

@sinoroc

sinoroc commented Aug 13, 2024

Copy link
Copy Markdown
Contributor

@webknjaz Can we get this merged? This is a straightforward fix. I was the one to write this page and introduce this mistake. I am sure this fix is correct.

@covracer covracer requested a review from webknjaz August 17, 2024 13:46
@covracer

covracer commented Aug 17, 2024

Copy link
Copy Markdown
Contributor Author

Thanks for the change! None of the commands should be run anymore. I think that this just states for the record that things still exist, but the document does not provide suggestions on how to deal with them right now. Removing one but leaving the others doesn't feel right. Not sure we'd want it in this form.

I don't understand.

Lines 21 to 26 list 4 commands as "MUST NOT be run": install, develop, sdist, bdist_wheel.

Lines 121 through 153 lists 25 commands as "remaining" or no recommended replacement.

I'm trying to fix the one overlapping element between the two lists.

I've updated the pull request description to be more specific. Please let me know if other changes are necessary to make the clarification acceptable.

@sinoroc

sinoroc commented Sep 24, 2024

Copy link
Copy Markdown
Contributor

@webknjaz @chrysle Can we get this merged? It is a simple, uncontroversial fix. I am the original author of this page, I know that this fix is correct.

@webknjaz webknjaz enabled auto-merge September 24, 2024 16:04
@webknjaz webknjaz added this pull request to the merge queue Sep 24, 2024
Merged via the queue into pypa:main with commit 363e4a6 Sep 24, 2024
@sinoroc

sinoroc commented Sep 24, 2024

Copy link
Copy Markdown
Contributor

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants