{{ message }}
BaseExtractor: fix _validate_archive_entries#4754
Draft
milahu wants to merge 2 commits into
Draft
Conversation
todo also debug
src/pyload/plugins/base/extractor.py
if normalized.startswith("/"):
raise ArchiveError(f"Attempted path traversal in archive: {entry}")
if self.dest is an absolute path then file_list has absolute paths so we must allow absolute paths
milahu
added a commit
to milahu/pyload
that referenced
this pull request
May 29, 2026
if self.dest is an absolute path then file_list has absolute paths so we must allow absolute paths pyload#4754
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
fix:
BaseExtractor._validate_archive_entriesfails on absoluteself.destpathsreproduce
the
Attempted path traversalerror makes no sensebecause the archive does not contain bad paths like
extractor plugins like
UnRarhad absolute file paths in
self.filessince foreverBaseExtractor._validate_archive_entrieshas been broken sinceif normalized.startswith("/"):C:/Users/...if os.path.isabs(entry_path):