{{ message }}
update parse_time in misc.py#2563
Open
igel-kun wants to merge 2 commits into
Open
Conversation
Contributor
Author
GammaC0de
reviewed
Sep 18, 2016
| seconds = seconds_to_midnight() | ||
|
|
||
| elif re.search("\d:\d\d", value): | ||
| # use the HH:MM:SS format, NOTE: when only one ':' is found, it assumes MM:SS |
Member
There was a problem hiding this comment.
Why assume MM:SS and not HH:MM?
Contributor
Author
There was a problem hiding this comment.
Well, there is no way around assuming one of the two without context, and seeing that I stumbled upon that while handling wait times (they were always below 1h), this seemed the obvious choice. However, to be more general, maybe an argument should be added to the function telling it how to interprete a single colon.
vuolter
added
enhancement
vuolter
added
invalid
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
added functionality to parse times in format
HH:MM:SSandMM:SS