{{ message }}
Repository navigation
PythonLexer: fix multiline string literals in brackets misidentified as docstrings - #3417
Open
Gabrieljr42 wants to merge 1 commit into
Open
Gabrieljr42 wants to merge 1 commit into
Gabrieljr42 wants to merge 1 commit into
Conversation
…as docstrings String literals starting on a new line inside parentheses, brackets, or braces were previously recognized as String.Doc because they matched the root docstring regexes. Track bracket nesting in expr so bracketed multiline strings remain regular string literals, while preserving true docstrings. Fixes pygments#3025.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes #3025.
Summary
String literals starting on a new line inside parentheses, brackets, or braces were previously recognized as
String.Docbecause they matched the root docstring regexes.This PR tracks bracket nesting (
expr-parens,expr-brackets,expr-braces) routing throughexpr-inside-bracketsso that bracketed multiline strings remain regular string literals, while preserving true docstrings. Also adds fallback punctuation handling for unmatched closers in code fragments.