Update github/codeql-action requirement to main by dependabot[bot] · Pull Request #29 · pwntester/codeql · GitHub
Skip to content

Update github/codeql-action requirement to main #29

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
dependabot wants to merge 7 commits into
base: main
Choose a base branch
from
Open

Update github/codeql-action requirement to main #29

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
7 commits
Select commit Hold shift + click to select a range
3c7fdc9
Add support for java.util.StringJoiner
pwntester Sep 22, 2022
db4db02
Add fluent models
atorralba Sep 22, 2022
0a1676b
Add change note
atorralba Sep 22, 2022
904ce25
Add models for StringJoiner constructor
atorralba Sep 22, 2022
e849acb
Add review suggestions
atorralba Sep 23, 2022
c9a3d61
Fix test comments
atorralba Sep 27, 2022
58be66e
Update github/codeql-action requirement to main
dependabot[bot] Feb 27, 2023
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
6 changes: 3 additions & 3 deletions .github/workflows/ql-for-ql-build.yml
View file
Open in desktop
2 changes: 1 addition & 1 deletion .github/workflows/ql-for-ql-dataset_measure.yml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -25,7 +25,7 @@ jobs:

- name: Find codeql
id: find-codeql
uses: github/codeql-action/init@71a8b35ff4c80fcfcd05bc1cd932fe3c08f943ca
uses: github/codeql-action/init@main
with:
languages: javascript # does not matter
- uses: actions/cache@v3
Expand Down
2 changes: 1 addition & 1 deletion .github/workflows/ql-for-ql-tests.yml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -22,7 +22,7 @@ jobs:
- uses: actions/checkout@v3
- name: Find codeql
id: find-codeql
uses: github/codeql-action/init@71a8b35ff4c80fcfcd05bc1cd932fe3c08f943ca
uses: github/codeql-action/init@main
with:
languages: javascript # does not matter
- uses: actions/cache@v3
Expand Down
4 changes: 4 additions & 0 deletions java/ql/lib/change-notes/2022-09-22-stringjoiner-summaries.md
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -0,0 +1,4 @@
---
category: minorAnalysis
---
* Added new flow steps for `java.util.StringJoiner`.
10 changes: 9 additions & 1 deletion java/ql/lib/semmle/code/java/frameworks/Strings.qll
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -64,7 +64,15 @@ private class StringSummaryCsv extends SummaryModelCsv {
"java.lang;StringBuilder;true;StringBuilder;;;Argument[0];Argument[-1];taint;manual",
"java.lang;CharSequence;true;charAt;;;Argument[-1];ReturnValue;taint;manual",
"java.lang;CharSequence;true;subSequence;;;Argument[-1];ReturnValue;taint;manual",
"java.lang;CharSequence;true;toString;;;Argument[-1];ReturnValue;taint;manual"
"java.lang;CharSequence;true;toString;;;Argument[-1];ReturnValue;taint;manual",
"java.util;StringJoiner;false;StringJoiner;;;Argument[0..2];Argument[-1];taint;manual",
"java.util;StringJoiner;false;add;;;Argument[0];Argument[-1];taint;manual",
"java.util;StringJoiner;false;add;;;Argument[-1];ReturnValue;value;manual",
"java.util;StringJoiner;false;merge;;;Argument[0];Argument[-1];taint;manual",
"java.util;StringJoiner;false;merge;;;Argument[-1];ReturnValue;value;manual",
"java.util;StringJoiner;false;setEmptyValue;;;Argument[0];Argument[-1];taint;manual",
"java.util;StringJoiner;false;setEmptyValue;;;Argument[-1];ReturnValue;value;manual",
"java.util;StringJoiner;false;toString;;;Argument[-1];ReturnValue;taint;manual",
]
}
}
92 changes: 92 additions & 0 deletions java/ql/test/library-tests/dataflow/taint/StringJoinerTests.java
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -0,0 +1,92 @@
import java.util.StringJoiner;

public class StringJoinerTests {

Object taint() {
return null;
}

void sink(Object o) {}

public void test() throws Exception {
{
// "java.util;StringJoiner;false;StringJoiner;(CharSequence);;Argument[0];Argument[-1];taint;manual"
StringJoiner out = null;
CharSequence in = (CharSequence) taint();
out = new StringJoiner(in);
sink(out);
}
{
// "java.util;StringJoiner;false;StringJoiner;(CharSequence,CharSequence,CharSequence);;Argument[0];Argument[-1];taint;manual"
StringJoiner out = null;
CharSequence in = (CharSequence) taint();
out = new StringJoiner(in, null, null);
sink(out);
}
{
// "java.util;StringJoiner;false;StringJoiner;(CharSequence,CharSequence,CharSequence);;Argument[1];Argument[-1];taint;manual"
StringJoiner out = null;
CharSequence in = (CharSequence) taint();
out = new StringJoiner(null, in, null);
sink(out);
}
{
// "java.util;StringJoiner;false;StringJoiner;(CharSequence,CharSequence,CharSequence);;Argument[2];Argument[-1];taint;manual"
StringJoiner out = null;
CharSequence in = (CharSequence) taint();
out = new StringJoiner(null, null, in);
sink(out);
}
{
// "java.util;StringJoiner;false;add;;;Argument[-1];ReturnValue;value;manual"
StringJoiner out = null;
StringJoiner in = (StringJoiner) taint();
out = in.add(null);
sink(out);
}
{
// "java.util;StringJoiner;false;add;;;Argument[0];Argument[-1];taint;manual"
StringJoiner out = null;
CharSequence in = (CharSequence) taint();
out.add(in);
sink(out);
}
{
// "java.util;StringJoiner;false;merge;;;Argument[-1];ReturnValue;value;manual"
StringJoiner out = null;
StringJoiner in = (StringJoiner) taint();
out = in.merge(null);
sink(out);
}
{
// "java.util;StringJoiner;false;merge;;;Argument[0];Argument[-1];taint;manual"
StringJoiner out = null;
StringJoiner in = (StringJoiner) taint();
out.merge(in);
sink(out);
}
{
// "java.util;StringJoiner;false;setEmptyValue;;;Argument[-1];ReturnValue;taint;manual"
StringJoiner out = null;
StringJoiner in = (StringJoiner) taint();
out = in.setEmptyValue(null);
sink(out);
}
{
// "java.util;StringJoiner;false;setEmptyValue;;;Argument[0];Argument[-1];taint;manual"
StringJoiner out = null;
CharSequence in = (CharSequence) taint();
out.setEmptyValue(in);
sink(out);
}
{
// "java.util;StringJoiner;false;toString;;;Argument[-1];ReturnValue;taint;manual"
String out = null;
StringJoiner in = (StringJoiner) taint();
out = in.toString();
sink(out);
}

}

}
11 changes: 11 additions & 0 deletions java/ql/test/library-tests/dataflow/taint/test.expected
View file
Open in desktop