{{ message }}
Remove deprecated pvsystem.sapm_spectral_loss#2244
Merged
Conversation
Member
kandersolar
reviewed
Mar 14, 2025
kandersolar
approved these changes
Mar 14, 2025
Member
|
In a similar sense to my own comment, to avoid links warnings with a Sphinx builder that checks them (linkchecker, with the Option
Otherwise, LGTM :D |
Co-authored-by: Kevin Anderson <kevin.anderso@gmail.com>
Co-Authored-By: Echedey Luis <80125792+echedey-ls@users.noreply.github.com>
…i/pvlib-python into remove_sapm_spectral_loss
Member
@RDaxini can you review the changes made to |
6 tasks
Member
kandersolar
added a commit
to kandersolar/pvlib-python
that referenced
this pull request
Mar 19, 2025
kandersolar
added a commit
that referenced
this pull request
Mar 19, 2025
* whatsnew cleanup * add missing contributors * fix minor docs error from #2244 * misc cleanup * rename 0.11.3 to 0.12.0 * add missed edits to contributing guide for new tests location * remove missed `fail_on_pvlib_version` decorator for get_am15g * remove duplicated entries * a few more rst fixes * Update docs/sphinx/source/whatsnew/v0.12.0.rst Co-authored-by: RDaxini <143435106+RDaxini@users.noreply.github.com> --------- Co-authored-by: RDaxini <143435106+RDaxini@users.noreply.github.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
pvsystem.sapm_spectral_lossnot removed #2243addedremoveddocs/sphinx/source/referencefor API changes.docs/sphinx/source/whatsnewfor all changes. Includes link to the GitHub Issue with:issue:`num`or this Pull Request with:pull:`num`. Includes contributor name and/or GitHub username (link with:ghuser:`user`).Wait for 12.0?
remote-data) and Milestone are assigned to the Pull Request and linked Issue.I am not super familiar with deprecations so please correct me if I have misunderstood something here or even missed an existing PR for this...