{{ message }}
Remove pvlib.forecast#1766
Merged
Merged
Conversation
Closed
Member
Author
Merged
8 tasks
AdamRJensen
approved these changes
Jun 14, 2023
AdamRJensen
left a comment
AdamRJensen
left a comment
Member
There was a problem hiding this comment.
I did a light review and things seem to check out.
kandersolar
added
remote-data
Member
Author
|
Hearing no objections, away it goes! |
Member
|
The end of an era! Thanks for cleaning up my mess! |
|
Hey, I am Stefan, a Student from Germany. Might I ask why you removed the feature ? I was going to use it for my masters thesis. |
Member
Author
|
Hello @stefan-hoermann, see #1057 and #1426 for discussion about this decision. I'm not sure if it will be helpful, but you might try searching the pvlib google group to see what other people are using instead of |
Member
|
@stefan-hoermann Note, you can always install previous versions of pvlib, which has the forecasting module, although not all of the functionality still works. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
docs/sphinx/source/referencefor API changes.docs/sphinx/source/whatsnewfor all changes. Includes link to the GitHub Issue with:issue:`num`or this Pull Request with:pull:`num`. Includes contributor name and/or GitHub username (link with:ghuser:`user`).[ ] New code is fully documented. Includes numpydoc compliant docstrings, examples, and comments where necessary.remote-data) and Milestone are assigned to the Pull Request and linked Issue.Following the thumbs up on #1735 (comment), this PR removes
pvlib.forecast. Removingpvlib.forecast, combined with #1654, means that several optional dependencies (siphon, netcdf4, cftime) are no longer used anywhere and can also be removed. This PR removes them here, but we should also remember to remove them from our conda-forge feedstock when we release v0.10.0.