{{ message }}
Use scipy.constants#1617
Merged
Merged
Conversation
Member
Member
Author
|
I searched but am not confident, because I didn't find that instance in temperature.py. I'm inclined to leave that one as is, with a comment. |
Member
|
One more place to update the minimum scipy version: |
wholmgren
approved these changes
Dec 20, 2022
wholmgren
left a comment
wholmgren
left a comment
Member
There was a problem hiding this comment.
Should we note the minimum version change in the release notes? I can go either way.
Member
I vote yes and am a fan of the format we've used previously: |
kandersolar
approved these changes
Dec 20, 2022
Contributor
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
docs/sphinx/source/whatsnewfor all changes. Includes link to the GitHub Issue with:issue:`num`or this Pull Request with:pull:`num`. Includes contributor name and/or GitHub username (link with:ghuser:`user`).remote-data) and Milestone are assigned to the Pull Request and linked Issue.In review of #1573 @markcampanelli pointed out that the precisely calculated solutions to the single diode equation should use the latest values of physical constants (Boltzmann and elementary charge). In 2019, the various committees agreed that the published values of these two constants were exact, without uncertainty. (I link to the U.S. agency NIST, other national agencies also published the same values).
With this agreement I see no reason for pvlib to use approximate values anywhere. Scipy 1.4.0 published the agreed-upon exact values in
scipy.constants. Advancing to scipy 1.4.0 does not require pvlib to also advance the numpy version.