clean up 0.8 whatsnew, other minor doc issues by wholmgren · Pull Request #1054 · pvlib/pvlib-python · GitHub
Skip to content

clean up 0.8 whatsnew, other minor doc issues#1054

Merged
wholmgren merged 11 commits into
pvlib:masterfrom
wholmgren:whatsnew08
Sep 8, 2020
Merged

clean up 0.8 whatsnew, other minor doc issues#1054
wholmgren merged 11 commits into
pvlib:masterfrom
wholmgren:whatsnew08

Conversation

@wholmgren

@wholmgren wholmgren commented Sep 7, 2020 •
edited
Loading

Copy link
Copy Markdown
Member
  • Closes change whats new API section names #1009
  • I am familiar with the contributing guidelines
  • Tests added
  • Updates entries to docs/sphinx/source/api.rst for API changes.
  • Adds description and name entries in the appropriate "what's new" file in docs/sphinx/source/whatsnew for all changes. Includes link to the GitHub Issue with :issue:`num` or this Pull Request with :pull:`num`. Includes contributor name and/or GitHub username (link with :ghuser:`user`).
  • New code is fully documented. Includes numpydoc compliant docstrings, examples, and comments where necessary.
  • Pull request is nearly complete and ready for detailed review.
  • Maintainer: Appropriate GitHub Labels and Milestone are assigned to the Pull Request and linked Issue.

Please let me know if I've missed any contributors to issue/PR discussions that were closed in this release.

@wholmgren wholmgren added this to the 0.8.0 milestone Sep 7, 2020
@wholmgren wholmgren mentioned this pull request Sep 7, 2020
Closed
kandersolar
kandersolar reviewed Sep 8, 2020
View reviewed changes

@kandersolar kandersolar left a comment

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

A handful of nits

Comment thread docs/sphinx/source/whatsnew/v0.8.0.rst Outdated
Comment thread docs/sphinx/source/whatsnew/v0.8.0.rst Outdated
Comment thread docs/sphinx/source/whatsnew/v0.8.0.rst
Comment thread docs/sphinx/source/whatsnew/v0.8.0.rst Outdated
Comment thread pvlib/ivtools/utils.py Outdated
Comment thread docs/sphinx/source/api.rst
wholmgren and others added 3 commits September 8, 2020 08:15
@wholmgren

wholmgren commented Sep 8, 2020

Copy link
Copy Markdown
Member Author

@mikofski

mikofski commented Sep 8, 2020 •
edited
Loading

Copy link
Copy Markdown
Member

This bullet in enhancements could be formatted:

Added racking_model, module_type, and temperature_model_parameters to PVSystem, LocalizedPVSystem, SingleAxisTracker, and LocalizedSingleAxisTracker repr methods. (GH1027)

I think the arguments should have double backticks and the classes should be linked to module index

mikofski
mikofski approved these changes Sep 8, 2020
View reviewed changes

@mikofski mikofski left a comment

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM! Thanks Will!

@cwhanse

cwhanse commented Sep 8, 2020

Copy link
Copy Markdown
Member

Only edit I saw, @mikofski noted.

@wholmgren

wholmgren commented Sep 8, 2020

Copy link
Copy Markdown
Member Author

@wholmgren wholmgren merged commit 72f3783 into pvlib:master Sep 8, 2020
@wholmgren wholmgren deleted the whatsnew08 branch September 8, 2020 21:33
@wholmgren wholmgren mentioned this pull request Sep 23, 2020
Merged
7 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@mikofski mikofski mikofski approved these changes
@kandersolar kandersolar kandersolar approved these changes

Assignees

No one assigned

Labels

documentation

Projects

None yet

Milestone

0.8.0

Development

Successfully merging this pull request may close these issues.

change whats new API section names

4 participants

@wholmgren @mikofski @cwhanse @kandersolar