Conversation
05ce511 to
69d382c
Compare
69d382c to
8ab0bcb
Compare
|
Looks like I forgot to check in the rc file for eslint. It should be there. I've removed the package lock file. A bit of confusion here, though; isn't it generally considered best practice to include it? Our npm dep tree on these isn't particularly sophisticated, but I would think that it would serve to remove one potential source of (admittedly unlikely) error. |
Update node dependencies and fix example.
8ab0bcb to
cc7dccc
Compare
|
rebased |
|
@hdgarrood Any thoughts on this? |
|
👍. I haven't had enough contact with recent versions of |
|
I don't think it should personally, since I've been adding it to the |
|
Oh wait, this one is set up to pull latests GH release too, so it also doesn't have a compiler version in the package.json, so disregard that part. |
|
The example provided by this PR seems good. We would need to fix the merge conflicts, update to |

Update node dependencies and fix example.